Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: src/liveedit.cc

Issue 227163008: Change exception type to Object. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/isolate.cc ('k') | src/messages.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 817 matching lines...) Expand 10 before | Expand all | Expand 10 after
828 v8::TryCatch try_catch; 828 v8::TryCatch try_catch;
829 try_catch.SetVerbose(true); 829 try_catch.SetVerbose(true);
830 830
831 // A logical 'try' section. 831 // A logical 'try' section.
832 Compiler::CompileForLiveEdit(script); 832 Compiler::CompileForLiveEdit(script);
833 } 833 }
834 834
835 // A logical 'catch' section. 835 // A logical 'catch' section.
836 Handle<JSObject> rethrow_exception; 836 Handle<JSObject> rethrow_exception;
837 if (isolate->has_pending_exception()) { 837 if (isolate->has_pending_exception()) {
838 Handle<Object> exception(isolate->pending_exception()->ToObjectChecked(), 838 Handle<Object> exception(isolate->pending_exception(), isolate);
839 isolate);
840 MessageLocation message_location = isolate->GetMessageLocation(); 839 MessageLocation message_location = isolate->GetMessageLocation();
841 840
842 isolate->clear_pending_message(); 841 isolate->clear_pending_message();
843 isolate->clear_pending_exception(); 842 isolate->clear_pending_exception();
844 843
845 // If possible, copy positions from message object to exception object. 844 // If possible, copy positions from message object to exception object.
846 if (exception->IsJSObject() && !message_location.script().is_null()) { 845 if (exception->IsJSObject() && !message_location.script().is_null()) {
847 rethrow_exception = Handle<JSObject>::cast(exception); 846 rethrow_exception = Handle<JSObject>::cast(exception);
848 847
849 Factory* factory = isolate->factory(); 848 Factory* factory = isolate->factory();
(...skipping 1155 matching lines...) Expand 10 before | Expand all | Expand 10 after
2005 2004
2006 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) { 2005 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) {
2007 return false; 2006 return false;
2008 } 2007 }
2009 2008
2010 #endif // ENABLE_DEBUGGER_SUPPORT 2009 #endif // ENABLE_DEBUGGER_SUPPORT
2011 2010
2012 2011
2013 2012
2014 } } // namespace v8::internal 2013 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/isolate.cc ('k') | src/messages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698