Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: components/favicon.gypi

Issue 227153007: Remove dependency on Profile's IsOffTheRecord in favicon_handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@FAVICON_create_core_dir
Patch Set: Review fixes. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/favicon.gypi
diff --git a/components/favicon.gypi b/components/favicon.gypi
index f9d4739f23c225b1e4a5e4300a70e05323e8f5bc..13a2151890a78f2058c5c67d2f26047095c0d2ea 100644
--- a/components/favicon.gypi
+++ b/components/favicon.gypi
@@ -7,9 +7,35 @@
{
'target_name': 'favicon_core',
'type': 'static_library',
+ 'include_dirs': [
+ '..',
+ ],
'sources': [
+ 'favicon/content/favicon_driver.h',
'favicon/core/favicon_handler_delegate.h',
],
},
],
+ 'conditions': [
+ ['OS != "ios"', {
+ 'targets': [
+ {
+ 'target_name': 'favicon_content',
+ 'type': 'static_library',
+ 'dependencies': [
+ 'favicon_core',
+ '../content/content.gyp:content_browser',
+ '../content/content.gyp:content_common',
+ ],
+ 'include_dirs': [
+ '..',
+ ],
+ 'sources': [
+ 'favicon/content/browser/content_favicon_driver.cc',
+ 'favicon/content/browser/content_favicon_driver.h',
+ ],
+ },
+ ],
+ }],
+ ],
}

Powered by Google App Engine
This is Rietveld 408576698