Remove dependency on Profile's IsOffTheRecord in favicon_handler.

chrome/browser/favicon/favicon_handler.h

Index: chrome/browser/favicon/favicon_handler.h
diff --git a/chrome/browser/favicon/favicon_handler.h b/chrome/browser/favicon/favicon_handler.h
index e25620af426ef6a492c8c743e22bc8c37ec121b4..ffa4c6017d2230e08db4b0670ea1fee003376444 100644
--- a/chrome/browser/favicon/favicon_handler.h
+++ b/chrome/browser/favicon/favicon_handler.h
@@ -19,6 +19,7 @@
 #include "ui/gfx/image/image.h"
 #include "url/gurl.h"
 
+class FaviconDriver;
 class FaviconHandlerDelegate;
 class Profile;
 class SkBitmap;
@@ -84,6 +85,7 @@ class FaviconHandler {
   };
 
   FaviconHandler(Profile* profile,
+                 FaviconDriver* driver,
                  FaviconHandlerDelegate* delegate,
                  Type icon_type);
   virtual ~FaviconHandler();
@@ -286,6 +288,9 @@ class FaviconHandler {
   // The Profile associated with this handler.
   Profile* profile_;
 
+  // The driver which implements platform-specific Favicon operations.
+  FaviconDriver* driver_;  // weak

[stevenjb, 2014/04/08 15:55:57]

I haven't seen "Driver" used much in Chrome code, and the meaning was not
immediately clear to me. Maybe use "PlatformDelegate" instead? Or would it be
possible just to integrate this with |delegate_|? That seems like it would be
simpler since FaviconHandlerDelegate already has a dependency on src/content for
GetActiveEntry.

[blundell, 2014/04/08 16:01:57]

FooDriver is the naming convention for the interface that abstracts the
dependencies that the core code of a layered component Foo has on the content
API.

In the medium term the FaviconHandlerDelegate will be integrated into the
FaviconDriver interface and content-based impl, yes.

On 2014/04/08 15:55:57, stevenjb wrote:

+
   // This handler's delegate.
   FaviconHandlerDelegate* delegate_;  // weak