Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3489)

Unified Diff: chrome/browser/favicon/favicon_tab_helper.cc

Issue 227153007: Remove dependency on Profile's IsOffTheRecord in favicon_handler. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@FAVICON_create_core_dir
Patch Set: Review fixes. Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/favicon/favicon_tab_helper.cc
diff --git a/chrome/browser/favicon/favicon_tab_helper.cc b/chrome/browser/favicon/favicon_tab_helper.cc
index 062ad873ea2c37a09c897df320123ec56d097cb9..daf95b1f4aa858b1cd5f9d83a74e76b36dce85c0 100644
--- a/chrome/browser/favicon/favicon_tab_helper.cc
+++ b/chrome/browser/favicon/favicon_tab_helper.cc
@@ -37,12 +37,13 @@ DEFINE_WEB_CONTENTS_USER_DATA_KEY(FaviconTabHelper);
FaviconTabHelper::FaviconTabHelper(WebContents* web_contents)
: content::WebContentsObserver(web_contents),
+ driver_(web_contents),
profile_(Profile::FromBrowserContext(web_contents->GetBrowserContext())) {
- favicon_handler_.reset(new FaviconHandler(profile_, this,
- FaviconHandler::FAVICON));
+ favicon_handler_.reset(
+ new FaviconHandler(profile_, &driver_, this, FaviconHandler::FAVICON));
if (chrome::kEnableTouchIcon)
- touch_icon_handler_.reset(new FaviconHandler(profile_, this,
- FaviconHandler::TOUCH));
+ touch_icon_handler_.reset(
+ new FaviconHandler(profile_, &driver_, this, FaviconHandler::TOUCH));
}
FaviconTabHelper::~FaviconTabHelper() {

Powered by Google App Engine
This is Rietveld 408576698