third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl - Issue 2271113002: Accept any string for currency code in PaymentRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl

Issue 2271113002: Accept any string for currency code in PaymentRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added browser side validation Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/junit/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java ('K') | « third_party/WebKit/LayoutTests/payments/payment-request-interface.html ('k') | third_party/WebKit/Source/modules/payments/PaymentRequestDetailsTest.cpp » ('j') | third_party/WebKit/public/platform/modules/payments/payment_request.mojom » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl

diff --git a/third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl b/third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl

index b022c715f15825c5a6376dc4f6c63eaa03c084af..fcc67d44c6a66823dd008ad856c7237a80bb58fc 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl

+++ b/third_party/WebKit/Source/modules/payments/PaymentCurrencyAmount.idl

@@ -7,6 +7,6 @@

[

RuntimeEnabled=PaymentRequest

] dictionary PaymentCurrencyAmount {

- required DOMString currency;

+ [TreatNullAs=NullString] required DOMString currency;

required DOMString value;

};