third_party/WebKit/public/platform/modules/payments/payment_request.mojom - Issue 2271113002: Accept any string for currency code in PaymentRequest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/payments/payment_request.mojom

Issue 2271113002: Accept any string for currency code in PaymentRequest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added browser side validation Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/junit/src/org/chromium/chrome/browser/payments/CurrencyStringFormatterTest.java ('K') | « third_party/WebKit/Source/modules/payments/PaymentsValidatorsTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/payments/payment_request.mojom

diff --git a/third_party/WebKit/public/platform/modules/payments/payment_request.mojom b/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

index dc29676287b9305099250111afb74bb15a1538b9..4186a23d07352c84c9465d4dc40d801752e0c39e 100644

--- a/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

+++ b/third_party/WebKit/public/platform/modules/payments/payment_request.mojom

@@ -36,7 +36,9 @@ struct PaymentAddress {

// browser shows the amount in UI and forwards it on to the payment app, if it

// requires the amount.

struct PaymentCurrencyAmount {

- // ISO 4217 currency code. Three upper case ASCII letters.

+ // The most common identifiers are three-letter alphabetic codes as defined

+ // by [ISO4217] (for example, "USD" for US Dollars), however any string is

+ // considered valid.

please use gerrit instead 2016/08/29 14:23:40 "any string of at most 2048 characters"

pals 2016/08/30 09:02:10 Done.

string currency;

// ISO 20022 CurrencyAnd30Amount. Up to 30 total digits. Up to 10 fraction