Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2271083002: Converted Observatory icdata-view element (Closed)

Created:
4 years, 4 months ago by cbernaschina
Modified:
4 years, 4 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Updated observatory_sources.gypi #

Total comments: 2

Patch Set 3 : Fixed layout & text #

Unified diffs Side-by-side diffs Delta from patch set Stats (+270 lines, -171 lines) Patch
M runtime/observatory/lib/elements.dart View 1 2 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/models.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 2 2 chunks +13 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/context_view.dart View 3 chunks +5 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/icdata_view.dart View 1 2 1 chunk +169 lines, -11 lines 0 comments Download
D runtime/observatory/lib/src/elements/icdata_view.html View 1 chunk +0 lines, -56 lines 0 comments Download
M runtime/observatory/lib/src/elements/object_common.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/models/objects/icdata.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/icdata.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + runtime/observatory/lib/src/repositories/icdata.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 3 chunks +2 lines, -1 line 0 comments Download
D runtime/observatory/tests/observatory_ui/context/element_test.dart View 1 chunk +0 lines, -58 lines 0 comments Download
D runtime/observatory/tests/observatory_ui/context/element_test.html View 1 chunk +0 lines, -20 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/context_view/element_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/context_view/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/icdata_view/element_test.dart View 2 chunks +12 lines, -12 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/icdata_view/element_test.html View 0 chunks +-1 lines, --1 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/tests/observatory_ui/mocks/objects/icdata.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A runtime/observatory/tests/observatory_ui/mocks/repositories/icdata.dart View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
cbernaschina
4 years, 4 months ago (2016-08-24 03:07:48 UTC) #2
cbernaschina
4 years, 4 months ago (2016-08-24 03:08:55 UTC) #3
Cutch
https://codereview.chromium.org/2271083002/diff/20001/runtime/observatory/lib/src/elements/icdata_view.dart File runtime/observatory/lib/src/elements/icdata_view.dart (right): https://codereview.chromium.org/2271083002/diff/20001/runtime/observatory/lib/src/elements/icdata_view.dart#newcode130 runtime/observatory/lib/src/elements/icdata_view.dart:130: new HeadingElement.h2()..text = 'Allocation Profile', fix text
4 years, 4 months ago (2016-08-24 13:59:17 UTC) #4
cbernaschina
https://codereview.chromium.org/2271083002/diff/20001/runtime/observatory/lib/src/elements/icdata_view.dart File runtime/observatory/lib/src/elements/icdata_view.dart (right): https://codereview.chromium.org/2271083002/diff/20001/runtime/observatory/lib/src/elements/icdata_view.dart#newcode130 runtime/observatory/lib/src/elements/icdata_view.dart:130: new HeadingElement.h2()..text = 'Allocation Profile', On 2016/08/24 13:59:17, Cutch ...
4 years, 4 months ago (2016-08-24 16:09:12 UTC) #5
Cutch
lgtm
4 years, 4 months ago (2016-08-24 16:27:23 UTC) #6
cbernaschina
4 years, 4 months ago (2016-08-24 16:33:47 UTC) #8
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
3d415d5ac0f4ec1f1f9428cc679acf0200f69e05 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698