runtime/observatory/lib/src/elements/object_common.dart - Issue 2271083002: Converted Observatory icdata-view element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/object_common.dart

Issue 2271083002: Converted Observatory icdata-view element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Fixed layout & text Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/lib/src/elements/object_common.dart

diff --git a/runtime/observatory/lib/src/elements/object_common.dart b/runtime/observatory/lib/src/elements/object_common.dart

index 8a144763fd47e7144f753a2b57d99ab7bf87cfeb..6426032cf8869b0394dacb6aba118f8658bbf2b8 100644

--- a/runtime/observatory/lib/src/elements/object_common.dart

+++ b/runtime/observatory/lib/src/elements/object_common.dart

@@ -111,7 +111,7 @@ class ObjectCommonElement extends HtmlElement implements Renderable {

new DivElement()..classes = const ['memberName']

..text = 'Shallow size ',

new DivElement()..classes = const ['memberValue']

- ..text = Utils.formatSize(_object.size)

+ ..text = Utils.formatSize(_object.size ?? 0)

new DivElement()..classes = const ['memberItem']

..title = 'Space reachable from this object, '