MD History: Add icon in top right of page when showing synced results

MD History: Add icon in top right of page when showing synced results

This adds an (i) button to top right of the page which, when clicked,
shows the 'Showing results from all your signed-in devices' message. The
message can be dismissed by clicking anywhere or pressing escape. It
will only show up for users with history sync enabled, on the main
history page.

BUG=622055
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e226eff5fb383a9a54ec74c95e245a206449a9f5
Cr-Commit-Position: refs/heads/master@{#418454}

[tsergeant, 2016-08-24 09:21:46]

Description was changed from

==========
MD History: Add icon in top right of page when showing synced results

This adds an (i) button to top right of the page which, when clicked,
shows the 'Showing results from all your signed-in devices' message. The
message can be dismissed by clicking anywhere or pressing escape. It
will only show up for users with history sync enabled, on the main
history page.

BUG=622055
==========

to

==========
MD History: Add icon in top right of page when showing synced results

This adds an (i) button to top right of the page which, when clicked,
shows the 'Showing results from all your signed-in devices' message. The
message can be dismissed by clicking anywhere or pressing escape. It
will only show up for users with history sync enabled, on the main
history page.

BUG=622055
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2016-08-29 01:36:42]

Patchset #2 (id:20001) has been deleted

[tsergeant, 2016-08-29 01:36:47]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-29 01:36:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-29 02:56:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-29 02:56:10]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[tsergeant, 2016-09-06 04:44:34]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-06 04:44:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-09-06 04:45:03]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[commit-bot: I haz the power, 2016-09-06 05:55:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-06 05:55:19]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-09-12 23:15:10]

Ping?

[calamity, 2016-09-13 03:12:25]

lgtm

https://codereview.chromium.org/2270993003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/2270993003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.html:6: <link rel="import"
href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
Are we getting rid of this soon?

https://codereview.chromium.org/2270993003/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_toolbar_test.js (right):

https://codereview.chromium.org/2270993003/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_toolbar_test.js:98:
app.set('queryState_.searchTerm', '');
Why is this set necessary?

[tsergeant, 2016-09-13 04:03:06]

https://codereview.chromium.org/2270993003/diff/60001/chrome/browser/resource...
File chrome/browser/resources/md_history/history_toolbar.html (right):

https://codereview.chromium.org/2270993003/diff/60001/chrome/browser/resource...
chrome/browser/resources/md_history/history_toolbar.html:6: <link rel="import"
href="chrome://resources/polymer/v1_0/paper-icon-button/paper-icon-button.html">
On 2016/09/13 03:12:24, calamity wrote:
> Are we getting rid of this soon?

We probably should. It's not high priority, but it should be a small
improvement.

https://codereview.chromium.org/2270993003/diff/60001/chrome/test/data/webui/...
File chrome/test/data/webui/md_history/history_toolbar_test.js (right):

https://codereview.chromium.org/2270993003/diff/60001/chrome/test/data/webui/...
chrome/test/data/webui/md_history/history_toolbar_test.js:98:
app.set('queryState_.searchTerm', '');
On 2016/09/13 03:12:24, calamity wrote:
> Why is this set necessary?

When this test runs, the search term changes and so the URL changes to
chrome://history/?q=something. This URL doesn't get reset when the app is
replaced, and so it keeps the tests from being independent.

(This whole file does not -need- to be changed as part of this CL, it's just
cleanup I did while looking at it. I can come back and do it separately if you
prefer).

[tsergeant, 2016-09-13 23:24:35]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 23:25:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2016-09-13 23:25:53]

I realised that modifying the existing IDS_HISTORY string is a Bad Idea since
it's used on Android, so I've changed them to IDS_MD_HISTORY strings

[commit-bot: I haz the power, 2016-09-14 00:43:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-14 00:43:57]

Dry run: This issue passed the CQ dry run.

[tsergeant, 2016-09-14 01:35:23]

The CQ bit was checked by tsergeant@chromium.org

[tsergeant, 2016-09-14 01:35:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2270993003/#ps80001
(title: "Move to MD-specific strings")

[commit-bot: I haz the power, 2016-09-14 01:35:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-14 01:59:45]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-09-14 02:01:50]

Description was changed from

==========
MD History: Add icon in top right of page when showing synced results

This adds an (i) button to top right of the page which, when clicked,
shows the 'Showing results from all your signed-in devices' message. The
message can be dismissed by clicking anywhere or pressing escape. It
will only show up for users with history sync enabled, on the main
history page.

BUG=622055
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Add icon in top right of page when showing synced results

This adds an (i) button to top right of the page which, when clicked,
shows the 'Showing results from all your signed-in devices' message. The
message can be dismissed by clicking anywhere or pressing escape. It
will only show up for users with history sync enabled, on the main
history page.

BUG=622055
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e226eff5fb383a9a54ec74c95e245a206449a9f5
Cr-Commit-Position: refs/heads/master@{#418454}
==========

[commit-bot: I haz the power, 2016-09-14 02:01:51]

Patchset 4 (id:??) landed as
https://crrev.com/e226eff5fb383a9a54ec74c95e245a206449a9f5
Cr-Commit-Position: refs/heads/master@{#418454}