chrome/browser/resources/md_history/history.js - Issue 2270993003: MD History: Add icon in top right of page when showing synced results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/md_history/history.js

Issue 2270993003: MD History: Add icon in top right of page when showing synced results (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@downloads_wide_toolbar

Patch Set: Move to MD-specific strings Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/md_history/app.vulcanized.html ('k') | chrome/browser/resources/md_history/history_toolbar.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/md_history/history.js

diff --git a/chrome/browser/resources/md_history/history.js b/chrome/browser/resources/md_history/history.js

index d25e8e92e1a2bba7eb5a35d545fdfa19c97e8ce8..522e8f9b32adc214841785c03666f0e42515827b 100644

--- a/chrome/browser/resources/md_history/history.js

+++ b/chrome/browser/resources/md_history/history.js

@@ -58,14 +58,10 @@ function historyResult(info, results) {

function showNotification(

hasSyncedResults, includeOtherFormsOfBrowsingHistory) {

- // TODO(msramek): |hasSyncedResults| was used in the old WebUI to show

- // the message about other signed-in devices. This message does not exist

- // in the MD history anymore, so the parameter is not needed. Remove it

- // when WebUI is removed and this becomes the only client of

- // BrowsingHistoryHandler.

waitForAppUpgrade().then(function() {

- /** @type {HistoryAppElement} */ ($('history-app')).showSidebarFooter =

- includeOtherFormsOfBrowsingHistory;

+ var app = /** @type {HistoryAppElement} */ ($('history-app'));

+ app.showSidebarFooter = includeOtherFormsOfBrowsingHistory;

+ app.hasSyncedResults = hasSyncedResults;

});

}