Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2149)

Unified Diff: scripts/slave/recipe_modules/auto_bisect/bisector.py

Issue 2270943002: Make Nexus5X bisect bot use 64 bit binaries. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/bisection/android_bisect.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/auto_bisect/bisector.py
diff --git a/scripts/slave/recipe_modules/auto_bisect/bisector.py b/scripts/slave/recipe_modules/auto_bisect/bisector.py
index 861ebbdc174bef0ecb9c06f02dd3be49413c7f1d..7a8a2399da20ba697d28083232c3c02374e2e9eb 100644
--- a/scripts/slave/recipe_modules/auto_bisect/bisector.py
+++ b/scripts/slave/recipe_modules/auto_bisect/bisector.py
@@ -807,8 +807,10 @@ class Bisector(object):
return 'winx64_bisect_builder'
return 'win_perf_bisect_builder'
+ # TODO(prasadv): Refactor this code to remove hard coded values and use
+ # target_bit from the bot config. crbug.com/640287
if 'android' in bot_name:
- if any(b in bot_name for b in ['arm64', 'nexus9']):
+ if any(b in bot_name for b in ['arm64', 'nexus9', 'nexus5X']):
return 'android_arm64_perf_bisect_builder'
return 'android_perf_bisect_builder'
@@ -835,8 +837,10 @@ class Bisector(object):
return 'gs://chrome-perf/Win x64 Builder/full-build-win32_'
return 'gs://chrome-perf/Win Builder/full-build-win32_'
+ # TODO(prasadv): Refactor this code to remove hard coded values and use
+ # target_bit from the bot config. crbug.com/640287
if 'android' in bot_name:
- if any(b in bot_name for b in ['arm64', 'nexus9']):
+ if any(b in bot_name for b in ['arm64', 'nexus9', 'nexus5X']):
return 'gs://chrome-perf/android_perf_rel_arm64/full-build-linux_'
return 'gs://chrome-perf/android_perf_rel/full-build-linux_'
« no previous file with comments | « no previous file | scripts/slave/recipes/bisection/android_bisect.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698