Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: scripts/slave/recipe_modules/auto_bisect/bisector.py

Issue 2270943002: Make Nexus5X bisect bot use 64 bit binaries. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | scripts/slave/recipes/bisection/android_bisect.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import json 5 import json
6 import re 6 import re
7 import time 7 import time
8 import urllib 8 import urllib
9 9
10 from . import config_validation 10 from . import config_validation
(...skipping 789 matching lines...) Expand 10 before | Expand all | Expand 10 after
800 if self.api.builder_bot: # pragma: no cover 800 if self.api.builder_bot: # pragma: no cover
801 return self.api.builder_bot 801 return self.api.builder_bot
802 802
803 # TODO(prasadv): Refactor this code to remove hard coded values. 803 # TODO(prasadv): Refactor this code to remove hard coded values.
804 bot_name = self.get_perf_tester_name() 804 bot_name = self.get_perf_tester_name()
805 if 'win' in bot_name: 805 if 'win' in bot_name:
806 if any(b in bot_name for b in ['x64', 'gpu']): 806 if any(b in bot_name for b in ['x64', 'gpu']):
807 return 'winx64_bisect_builder' 807 return 'winx64_bisect_builder'
808 return 'win_perf_bisect_builder' 808 return 'win_perf_bisect_builder'
809 809
810 # TODO(prasadv): Refactor this code to remove hard coded values and use
811 # target_bit from the bot config. crbug.com/640287
810 if 'android' in bot_name: 812 if 'android' in bot_name:
811 if any(b in bot_name for b in ['arm64', 'nexus9']): 813 if any(b in bot_name for b in ['arm64', 'nexus9', 'nexus5X']):
812 return 'android_arm64_perf_bisect_builder' 814 return 'android_arm64_perf_bisect_builder'
813 return 'android_perf_bisect_builder' 815 return 'android_perf_bisect_builder'
814 816
815 if 'mac' in bot_name: 817 if 'mac' in bot_name:
816 return 'mac_perf_bisect_builder' 818 return 'mac_perf_bisect_builder'
817 819
818 return 'linux_perf_bisect_builder' 820 return 'linux_perf_bisect_builder'
819 821
820 def get_platform_gs_prefix(self): 822 def get_platform_gs_prefix(self):
821 """Returns the prefix of a GS URL where a build can be found. 823 """Returns the prefix of a GS URL where a build can be found.
822 824
823 This prefix includes the schema, bucket, directory and beginning 825 This prefix includes the schema, bucket, directory and beginning
824 of filename. It is joined together with the part of the filename 826 of filename. It is joined together with the part of the filename
825 that includes the revision and the file extension to form the 827 that includes the revision and the file extension to form the
826 full GS URL. 828 full GS URL.
827 """ 829 """
828 if self.api.buildurl_gs_prefix: # pragma: no cover 830 if self.api.buildurl_gs_prefix: # pragma: no cover
829 return self.api.buildurl_gs_prefix 831 return self.api.buildurl_gs_prefix
830 832
831 # TODO(prasadv): Refactor this code to remove hard coded values. 833 # TODO(prasadv): Refactor this code to remove hard coded values.
832 bot_name = self.get_perf_tester_name() 834 bot_name = self.get_perf_tester_name()
833 if 'win' in bot_name: 835 if 'win' in bot_name:
834 if any(b in bot_name for b in ['x64', 'gpu']): 836 if any(b in bot_name for b in ['x64', 'gpu']):
835 return 'gs://chrome-perf/Win x64 Builder/full-build-win32_' 837 return 'gs://chrome-perf/Win x64 Builder/full-build-win32_'
836 return 'gs://chrome-perf/Win Builder/full-build-win32_' 838 return 'gs://chrome-perf/Win Builder/full-build-win32_'
837 839
840 # TODO(prasadv): Refactor this code to remove hard coded values and use
841 # target_bit from the bot config. crbug.com/640287
838 if 'android' in bot_name: 842 if 'android' in bot_name:
839 if any(b in bot_name for b in ['arm64', 'nexus9']): 843 if any(b in bot_name for b in ['arm64', 'nexus9', 'nexus5X']):
840 return 'gs://chrome-perf/android_perf_rel_arm64/full-build-linux_' 844 return 'gs://chrome-perf/android_perf_rel_arm64/full-build-linux_'
841 return 'gs://chrome-perf/android_perf_rel/full-build-linux_' 845 return 'gs://chrome-perf/android_perf_rel/full-build-linux_'
842 846
843 if 'mac' in bot_name: 847 if 'mac' in bot_name:
844 return 'gs://chrome-perf/Mac Builder/full-build-mac_' 848 return 'gs://chrome-perf/Mac Builder/full-build-mac_'
845 849
846 return 'gs://chrome-perf/Linux Builder/full-build-linux_' 850 return 'gs://chrome-perf/Linux Builder/full-build-linux_'
847 851
848 def ensure_sync_master_branch(self): 852 def ensure_sync_master_branch(self):
849 """Make sure the local master is in sync with the fetched origin/master. 853 """Make sure the local master is in sync with the fetched origin/master.
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
946 }) 950 })
947 return revision_rows 951 return revision_rows
948 952
949 def _get_build_url(self): 953 def _get_build_url(self):
950 properties = self.api.m.properties 954 properties = self.api.m.properties
951 bot_url = properties.get('buildbotURL', 955 bot_url = properties.get('buildbotURL',
952 'http://build.chromium.org/p/chromium/') 956 'http://build.chromium.org/p/chromium/')
953 builder_name = urllib.quote(properties.get('buildername', '')) 957 builder_name = urllib.quote(properties.get('buildername', ''))
954 builder_number = str(properties.get('buildnumber', '')) 958 builder_number = str(properties.get('buildnumber', ''))
955 return '%sbuilders/%s/builds/%s' % (bot_url, builder_name, builder_number) 959 return '%sbuilders/%s/builds/%s' % (bot_url, builder_name, builder_number)
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/bisection/android_bisect.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698