Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2270913002: fix icon toggling off bug by removing the line that disable window animation

Created:
4 years, 4 months ago by ftang
Modified:
4 years, 3 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

fix icon toggling off bug by removing the line that disable window animation BUG=636637

Patch Set 1 #

Patch Set 2 : fix unit test breakage which was shadowed by the disable of window animation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M chrome/browser/translate/translate_manager_render_view_host_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
ftang
4 years, 4 months ago (2016-08-24 02:23:34 UTC) #6
groby-ooo-7-16
On 2016/08/24 02:23:34, ftang wrote: To update from our chat conversation: That still should crash ...
4 years, 3 months ago (2016-09-06 18:57:16 UTC) #7
groby-ooo-7-16
4 years, 3 months ago (2016-09-06 18:57:17 UTC) #8
On 2016/08/24 02:23:34, ftang wrote:

To update from our chat conversation: That still should crash on OSX.

Powered by Google App Engine
This is Rietveld 408576698