chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm - Issue 2270913002: fix icon toggling off bug by removing the line that disable window animation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm

Issue 2270913002: fix icon toggling off bug by removing the line that disable window animation Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix unit test breakage which was shadowed by the disable of window animation Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm b/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm

index 75d30552b027833bfc7b8ec7c90734fa41608ab7..e7f0f2f095fe85441d5125d56f8c038e493f29cb 100644

--- a/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/translate/translate_bubble_controller.mm

@@ -150,10 +150,6 @@ const CGFloat kContentWidth = kWindowWidth - 2 * kFramePadding;

backing:NSBackingStoreBuffered

defer:NO]);

- // Disable animations - otherwise, the window/controller will outlive the web

- // contents it's associated with.

- [window setAllowedAnimations:info_bubble::kAnimateNone];

if ((self = [super initWithWindow:window

parentWindow:parentWindow

anchoredAt:NSZeroPoint])) {

« no previous file with comments | « chrome/browser/translate/translate_manager_render_view_host_unittest.cc ('k') | no next file » | no next file with comments »