Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2270873002: Put WebAPK Android Manifest keys in dedicated file (Closed)

Created:
4 years, 4 months ago by pkotwicz
Modified:
4 years, 4 months ago
Reviewers:
Xi Han, gone
CC:
chromium-reviews, dominickn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Put WebAPK Android Manifest keys in dedicated file BUG=None TEST=None Committed: https://crrev.com/5d8428b5e4a5d594eacd88b155b6ea9b5218736d Cr-Commit-Position: refs/heads/master@{#414179}

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into meta_data_class #

Patch Set 3 : Merge branch 'master' into meta_data_class #

Messages

Total messages: 19 (10 generated)
pkotwicz
Xi can you please take a look? This CL is in response to Yaron's comments ...
4 years, 4 months ago (2016-08-23 15:44:17 UTC) #2
Xi Han
lgtm. Please update WebApkUtils.java (https://cs.chromium.org/chromium/src/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkUtils.java?rcl=0&l=53), thanks!
4 years, 4 months ago (2016-08-24 13:34:32 UTC) #3
pkotwicz
dfalcantara@ for OWNERS Thank you Xi I missed that one
4 years, 4 months ago (2016-08-24 14:14:48 UTC) #6
gone
lgtm
4 years, 4 months ago (2016-08-24 18:22:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270873002/20001
4 years, 4 months ago (2016-08-24 18:56:18 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/117853)
4 years, 4 months ago (2016-08-24 19:21:31 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270873002/40001
4 years, 4 months ago (2016-08-24 19:39:46 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-24 22:41:09 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 22:44:46 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5d8428b5e4a5d594eacd88b155b6ea9b5218736d
Cr-Commit-Position: refs/heads/master@{#414179}

Powered by Google App Engine
This is Rietveld 408576698