Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/MainActivityTest.java

Issue 2270873002: Put WebAPK Android Manifest keys in dedicated file (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Merge branch 'master' into meta_data_class Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/MainActivityTest.java
diff --git a/chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/MainActivityTest.java b/chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/MainActivityTest.java
index cb8e909111ea6e461fada019705b77249a425888..bba040ddba3b084b7281796740a267d55ee9b1c2 100644
--- a/chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/MainActivityTest.java
+++ b/chrome/android/webapk/shell_apk/junit/src/org/chromium/webapk/shell_apk/MainActivityTest.java
@@ -12,6 +12,7 @@ import android.content.pm.ResolveInfo;
import android.os.Bundle;
import org.chromium.testing.local.LocalRobolectricTestRunner;
+import org.chromium.webapk.lib.common.WebApkMetaDataKeys;
import org.junit.Assert;
import org.junit.Before;
@@ -34,16 +35,6 @@ public class MainActivityTest {
private static final String PACKAGE_NAME = "package_name";
private static final String HOST_BROWSER_PACKAGE_NAME = "truly.random";
- /**
- * <meta-data> key in the Android Manifest for the host browser's package name.
- */
- private static final String META_RUNTIME_HOST = "org.chromium.webapk.shell_apk.runtimeHost";
-
- /**
- * <meta-data> key in Android Manifest for the start URL.
- */
- private static final String META_START_URL = "org.chromium.webapk.shell_apk.startUrl";
-
private ShadowApplication mShadowApplication;
private RobolectricPackageManager mPackageManager;
@@ -66,8 +57,8 @@ public class MainActivityTest {
// Set WebAPK's meta-data.
Bundle metaData = new Bundle();
- metaData.putString(META_RUNTIME_HOST, HOST_BROWSER_PACKAGE_NAME);
- metaData.putString(META_START_URL, "http://random.org");
+ metaData.putString(WebApkMetaDataKeys.RUNTIME_HOST, HOST_BROWSER_PACKAGE_NAME);
+ metaData.putString(WebApkMetaDataKeys.START_URL, "http://random.org");
mPackageManager.addPackage(newPackageInfo(PACKAGE_NAME, metaData));
// Make intents to Google Play not throw ActivityNotFoundException.
@@ -93,8 +84,8 @@ public class MainActivityTest {
// Set WebAPK's meta-data.
Bundle metaData = new Bundle();
- metaData.putString(META_RUNTIME_HOST, HOST_BROWSER_PACKAGE_NAME);
- metaData.putString(META_START_URL, "http://random.org");
+ metaData.putString(WebApkMetaDataKeys.RUNTIME_HOST, HOST_BROWSER_PACKAGE_NAME);
+ metaData.putString(WebApkMetaDataKeys.START_URL, "http://random.org");
mPackageManager.addPackage(newPackageInfo(PACKAGE_NAME, metaData));
Robolectric.buildActivity(MainActivity.class).create();

Powered by Google App Engine
This is Rietveld 408576698