Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2270833003: GN: extract optional() as a template and use for giflib-dependent code (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

GN: extract optional() as a template and use for giflib-dependent code BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2270833003 Committed: https://skia.googlesource.com/skia/+/457b42a6398020c3791f62f8c8637653e0d39bcc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -21 lines) Patch
M BUILD.gn View 4 chunks +54 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
mtklein_C
More to come... should be quicker now that I've figured out how to make this ...
4 years, 4 months ago (2016-08-23 20:15:47 UTC) #7
jcgregorio
lgtm
4 years, 4 months ago (2016-08-23 20:42:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270833003/1
4 years, 4 months ago (2016-08-23 20:55:44 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 20:56:40 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/457b42a6398020c3791f62f8c8637653e0d39bcc

Powered by Google App Engine
This is Rietveld 408576698