Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 2270793004: [turbofan] Fix merging of empty and non-empty state in load elimination. (Closed)

Created:
4 years, 4 months ago by Jarin
Modified:
4 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix merging of empty and non-empty state in load elimination. Unfortunately, I was unable to produce a repro without asm.js. In normal JavaScript, the bounds check renaming saves us. I have not done anything about the index variable aliasing and handling of differently sized elements yet! BUG=chromium:639210, v8:5266 Committed: https://crrev.com/dc330f2bd35656ecc133f7f329edee302a809935 Cr-Commit-Position: refs/heads/master@{#38874}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -3 lines) Patch
M src/compiler/load-elimination.cc View 1 chunk +1 line, -3 lines 0 comments Download
A test/mjsunit/compiler/regress-639210.js View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Jarin
Could you take a look, please?
4 years, 4 months ago (2016-08-24 15:09:49 UTC) #4
Benedikt Meurer
Awesome, thanks. LGTM.
4 years, 4 months ago (2016-08-24 17:11:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270793004/1
4 years, 4 months ago (2016-08-24 17:12:01 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 17:14:02 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 17:14:33 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc330f2bd35656ecc133f7f329edee302a809935
Cr-Commit-Position: refs/heads/master@{#38874}

Powered by Google App Engine
This is Rietveld 408576698