Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: src/compiler/load-elimination.cc

Issue 2270793004: [turbofan] Fix merging of empty and non-empty state in load elimination. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/compiler/regress-639210.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/load-elimination.cc
diff --git a/src/compiler/load-elimination.cc b/src/compiler/load-elimination.cc
index ad787f80928be553075a3e130fd534b9fc478eaa..6131fc57d4ec333ef6eac76a01640aac21607d53 100644
--- a/src/compiler/load-elimination.cc
+++ b/src/compiler/load-elimination.cc
@@ -219,9 +219,7 @@ void LoadElimination::AbstractState::Merge(AbstractState const* that,
if (this->elements_) {
this->elements_ = that->elements_
? that->elements_->Merge(this->elements_, zone)
- : that->elements_;
- } else {
- this->elements_ = that->elements_;
+ : nullptr;
}
// Merge the information we have about the fields.
« no previous file with comments | « no previous file | test/mjsunit/compiler/regress-639210.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698