|
|
Chromium Code Reviews
Descriptionclang/win: Make builds work with MSVC2015 update 3.
The midl compiler now produces slightly questionable code that clang-cl warns
on. The warning is no longer emitted in upstream clang-cl, but until we roll
that in, suppress it so that people who locally use update 3 are able to build
with clang.
BUG=637456, 627216, 640000
NOTRY=true
Committed: https://crrev.com/109db8b6fcdb52a55e40c44128a9cf36c00a5649
Cr-Commit-Position: refs/heads/master@{#414083}
Patch Set 1 #
Messages
Total messages: 21 (15 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== clang/win: Make builds work with MSVC2015 update 3. The midl compiler now produces slightly questionable code that clang-cl warns on. The warning is no longer emitted in upstream clang-cl, but until we roll that in, suppress it so that people who locally use update 3 are able to build with clang. BUG=637456, 627216 ========== to ========== clang/win: Make builds work with MSVC2015 update 3. The midl compiler now produces slightly questionable code that clang-cl warns on. The warning is no longer emitted in upstream clang-cl, but until we roll that in, suppress it so that people who locally use update 3 are able to build with clang. BUG=637456, 627216, 640000 ==========
thakis@chromium.org changed reviewers: + brucedawson@chromium.org, hans@chromium.org, rnk@chromium.org
First to stamp wins!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by thakis@chromium.org
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by thakis@chromium.org
Description was changed from ========== clang/win: Make builds work with MSVC2015 update 3. The midl compiler now produces slightly questionable code that clang-cl warns on. The warning is no longer emitted in upstream clang-cl, but until we roll that in, suppress it so that people who locally use update 3 are able to build with clang. BUG=637456, 627216, 640000 ========== to ========== clang/win: Make builds work with MSVC2015 update 3. The midl compiler now produces slightly questionable code that clang-cl warns on. The warning is no longer emitted in upstream clang-cl, but until we roll that in, suppress it so that people who locally use update 3 are able to build with clang. BUG=637456, 627216, 640000 NOTRY=true ==========
The CQ bit was checked by thakis@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== clang/win: Make builds work with MSVC2015 update 3. The midl compiler now produces slightly questionable code that clang-cl warns on. The warning is no longer emitted in upstream clang-cl, but until we roll that in, suppress it so that people who locally use update 3 are able to build with clang. BUG=637456, 627216, 640000 NOTRY=true ========== to ========== clang/win: Make builds work with MSVC2015 update 3. The midl compiler now produces slightly questionable code that clang-cl warns on. The warning is no longer emitted in upstream clang-cl, but until we roll that in, suppress it so that people who locally use update 3 are able to build with clang. BUG=637456, 627216, 640000 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== clang/win: Make builds work with MSVC2015 update 3. The midl compiler now produces slightly questionable code that clang-cl warns on. The warning is no longer emitted in upstream clang-cl, but until we roll that in, suppress it so that people who locally use update 3 are able to build with clang. BUG=637456, 627216, 640000 NOTRY=true ========== to ========== clang/win: Make builds work with MSVC2015 update 3. The midl compiler now produces slightly questionable code that clang-cl warns on. The warning is no longer emitted in upstream clang-cl, but until we roll that in, suppress it so that people who locally use update 3 are able to build with clang. BUG=637456, 627216, 640000 NOTRY=true Committed: https://crrev.com/109db8b6fcdb52a55e40c44128a9cf36c00a5649 Cr-Commit-Position: refs/heads/master@{#414083} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/109db8b6fcdb52a55e40c44128a9cf36c00a5649 Cr-Commit-Position: refs/heads/master@{#414083} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
