build/config/win/BUILD.gn - Issue 2270693008: clang/win: Make builds work with MSVC2015 update 3.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/win/BUILD.gn

Issue 2270693008: clang/win: Make builds work with MSVC2015 update 3. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/win/BUILD.gn

diff --git a/build/config/win/BUILD.gn b/build/config/win/BUILD.gn

index a65997bf44c0f0bae8c794aee8bba499f30db3da..c778bf2ab4f9df95145610eaa9fdaf1c5b7bb4b6 100644

--- a/build/config/win/BUILD.gn

+++ b/build/config/win/BUILD.gn

@@ -402,7 +402,13 @@ config("target_winrt") {

# Config used by the MIDL template to disable warnings.

config("midl_warnings") {

if (is_clang) {

- # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_".

- cflags = [ "-Wno-extra-tokens" ]

+ cflags = [

+ # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_".

+ "-Wno-extra-tokens",

+ # TODO(thakis): Remove this once clang is rolled past r279116,

+ # https://crbug.com/637456

+ "-Wno-extern-initializer",

+ ]

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »