Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2270693003:
Clean up DispatchTo{Function,Method} impl (Closed)
DescriptionClean up DispatchTo{Function,Method} impl
* Remove Unwrap call, which is no longer needed after http://crrev.com/2268283002
* Use Perfect Forwarding on Dispatch{Function,Method}
Committed: https://crrev.com/2387a82551340c8b9e3e00ed3e7329fbeda22ba9
Cr-Commit-Position: refs/heads/master@{#414424}
Patch Set 1 #Patch Set 2 : fix #Patch Set 3 : rebase #
Depends on Patchset: Messages
Total messages: 21 (16 generated)
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
Description was changed from ========== Remove base::internal::Unwrap usage in base/tuple.h BUG= ========== to ========== Remove base::internal::Unwrap usage in base/tuple.h BUG= ==========
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from
==========
Remove base::internal::Unwrap usage in base/tuple.h
BUG=
==========
to
==========
Clean up DispatchTo{Function,Method} impl
* Remove Unwrap call, which is no longer needed after
http://crrev.com/2268283002
* Use Perfect Forwarding on Dispatch{Function,Method}
==========
tzik@chromium.org changed reviewers: + dcheng@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by tzik@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
Clean up DispatchTo{Function,Method} impl
* Remove Unwrap call, which is no longer needed after
http://crrev.com/2268283002
* Use Perfect Forwarding on Dispatch{Function,Method}
==========
to
==========
Clean up DispatchTo{Function,Method} impl
* Remove Unwrap call, which is no longer needed after
http://crrev.com/2268283002
* Use Perfect Forwarding on Dispatch{Function,Method}
==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from
==========
Clean up DispatchTo{Function,Method} impl
* Remove Unwrap call, which is no longer needed after
http://crrev.com/2268283002
* Use Perfect Forwarding on Dispatch{Function,Method}
==========
to
==========
Clean up DispatchTo{Function,Method} impl
* Remove Unwrap call, which is no longer needed after
http://crrev.com/2268283002
* Use Perfect Forwarding on Dispatch{Function,Method}
Committed: https://crrev.com/2387a82551340c8b9e3e00ed3e7329fbeda22ba9
Cr-Commit-Position: refs/heads/master@{#414424}
==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/2387a82551340c8b9e3e00ed3e7329fbeda22ba9 Cr-Commit-Position: refs/heads/master@{#414424} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
