Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2268283002: Replace DispatchToMethod in ObserverListThreadSafe with Bind (Closed)

Created:
4 years, 4 months ago by tzik
Modified:
4 years, 4 months ago
Reviewers:
dcheng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace DispatchToMethod in ObserverListThreadSafe with Bind This CL removes DispatchToMethod usage in ObserverListThreadSafe, which is the only user of DispatchToMethod that depends on base::internal::Unwrap. Committed: https://crrev.com/b7990ccd06f70258850dd2159e0a14d33aa910a0 Cr-Commit-Position: refs/heads/master@{#414260}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -25 lines) Patch
M base/observer_list_threadsafe.h View 3 chunks +16 lines, -25 lines 2 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (9 generated)
tzik
PTAL
4 years, 4 months ago (2016-08-23 12:00:43 UTC) #5
dcheng
lgtm https://codereview.chromium.org/2268283002/diff/1/base/observer_list_threadsafe.h File base/observer_list_threadsafe.h (left): https://codereview.chromium.org/2268283002/diff/1/base/observer_list_threadsafe.h#oldcode71 base/observer_list_threadsafe.h:71: "bad unbound method params"); If I understand correctly, ...
4 years, 4 months ago (2016-08-24 21:18:27 UTC) #8
tzik
https://codereview.chromium.org/2268283002/diff/1/base/observer_list_threadsafe.h File base/observer_list_threadsafe.h (left): https://codereview.chromium.org/2268283002/diff/1/base/observer_list_threadsafe.h#oldcode71 base/observer_list_threadsafe.h:71: "bad unbound method params"); On 2016/08/24 21:18:27, dcheng wrote: ...
4 years, 4 months ago (2016-08-25 00:53:01 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2268283002/1
4 years, 4 months ago (2016-08-25 00:54:15 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-25 02:19:52 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-25 02:23:28 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7990ccd06f70258850dd2159e0a14d33aa910a0
Cr-Commit-Position: refs/heads/master@{#414260}

Powered by Google App Engine
This is Rietveld 408576698