Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Issue 2270613003: Remove some useless declarations (Closed)

Created:
4 years, 4 months ago by sylvestre
Modified:
4 years, 3 months ago
Reviewers:
jcgregorio, mtklein, reed1
CC:
jcgregorio, reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Remove a useless check, here, the value of 'a' must be at least 256 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M src/core/SkConvolver.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
jcgregorio
4 years, 3 months ago (2016-09-01 14:06:14 UTC) #6
reed1
seems fine... others?
4 years, 3 months ago (2016-09-01 15:39:24 UTC) #12
mtklein
lgtm
4 years, 3 months ago (2016-09-01 15:46:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270613003/1
4 years, 3 months ago (2016-09-01 15:46:51 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 15:47:47 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/d0cd2ecf31bb49988bc8a7ff74ee05161c9538de

Powered by Google App Engine
This is Rietveld 408576698