src/core/SkConvolver.cpp - Issue 2270613003: Remove some useless declarations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkConvolver.cpp

Issue 2270613003: Remove some useless declarations (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Remove a useless check, here, the value of 'a' must be at least 256 Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkConvolver.cpp

diff --git a/src/core/SkConvolver.cpp b/src/core/SkConvolver.cpp

index c662e2ddaf0db82e0e40b5dd1c5c86ed4dd39206..5f0dc0b97f2a078a8f6a1c312bd94096686c5b3c 100644

--- a/src/core/SkConvolver.cpp

+++ b/src/core/SkConvolver.cpp

@@ -13,9 +13,6 @@ namespace {

if (static_cast<unsigned>(a) < 256) {

return a; // Avoid the extra check in the common case.

}

- if (a < 0) {

- return 0;

- }

return 255;

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »