Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2270583003:
Add rules.aar (Closed)
|
Created:
4 years, 4 months ago by the real yoland Modified:
4 years, 3 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd exposed-instrumentation-api jar and rules jar
BUG=640116
Committed: https://crrev.com/9daee8af2bfb497448394ab3b5e7e76d81225bb1
Cr-Commit-Position: refs/heads/master@{#417696}
Patch Set 1 #
Total comments: 4
Patch Set 2 : Fix language barrier #
Total comments: 4
Patch Set 3 : Add rules aar file #Patch Set 4 : Rebase #
Messages
Total messages: 22 (5 generated)
yolandyan@chromium.org changed reviewers: + jbudorick@chromium.org, mikecase@chromium.org
yolandyan@chromium.org changed reviewers: + aluo@chromium.org
https://codereview.chromium.org/2270583003/diff/1/third_party/android_support... File third_party/android_support_test_runner/BUILD.gn (right): https://codereview.chromium.org/2270583003/diff/1/third_party/android_support... third_party/android_support_test_runner/BUILD.gn:19: android_java_prebuilt("rules_java") { Where is rules_java used? Should it also be part of the runner_java deps? https://codereview.chromium.org/2270583003/diff/1/third_party/android_support... File third_party/android_support_test_runner/README.chromium (right): https://codereview.chromium.org/2270583003/diff/1/third_party/android_support... third_party/android_support_test_runner/README.chromium:10: There static jars are part of Android Testing Support Library. They are needed nit: There->These
https://codereview.chromium.org/2270583003/diff/1/third_party/android_support... File third_party/android_support_test_runner/BUILD.gn (right): https://codereview.chromium.org/2270583003/diff/1/third_party/android_support... third_party/android_support_test_runner/BUILD.gn:19: android_java_prebuilt("rules_java") { On 2016/08/24 at 00:09:32, jbudorick wrote: > Where is rules_java used? Should it also be part of the runner_java deps? I think we should have a complete runner jar with all dependencies included. Will look into that https://codereview.chromium.org/2270583003/diff/1/third_party/android_support... File third_party/android_support_test_runner/README.chromium (right): https://codereview.chromium.org/2270583003/diff/1/third_party/android_support... third_party/android_support_test_runner/README.chromium:10: There static jars are part of Android Testing Support Library. They are needed On 2016/08/24 at 00:09:32, jbudorick wrote: > nit: There->These Done
https://codereview.chromium.org/2270583003/diff/20001/third_party/android_sup... File third_party/android_support_test_runner/BUILD.gn (right): https://codereview.chromium.org/2270583003/diff/20001/third_party/android_sup... third_party/android_support_test_runner/BUILD.gn:20: android_java_prebuilt("rules_java") { Until you've got a complete runner jar, what's this expected to do? How will this be used?
We need to coordinate with Andrew because he is adding runner-0.5 in this CL. Idk if that means we should have you add rules-0.5 or have Andrew not update the runner jar. Also him and you are both adding the exposed_instrumenteation_api jar https://codereview.chromium.org/2142413004
https://codereview.chromium.org/2270583003/diff/20001/third_party/android_sup... File third_party/android_support_test_runner/BUILD.gn (right): https://codereview.chromium.org/2270583003/diff/20001/third_party/android_sup... third_party/android_support_test_runner/BUILD.gn:17: jar_path = "lib/exposed-instrumentation-api-publish-0.3-release-no-dep.jar" I'm updating the exposed instrumentation api and runner to 0.5 version, see https://codereview.chromium.org/2142413004. Unless there's a specific reason to use 0.3, you can omit this prebuilt and update the rules to 0.5 below after my cl lands. Please let me know so I can land 2142413004, thanks.
On 2016/08/24 at 17:13:36, aluo wrote: > https://codereview.chromium.org/2270583003/diff/20001/third_party/android_sup... > File third_party/android_support_test_runner/BUILD.gn (right): > > https://codereview.chromium.org/2270583003/diff/20001/third_party/android_sup... > third_party/android_support_test_runner/BUILD.gn:17: jar_path = "lib/exposed-instrumentation-api-publish-0.3-release-no-dep.jar" > I'm updating the exposed instrumentation api and runner to 0.5 version, see https://codereview.chromium.org/2142413004. Unless there's a specific reason to use 0.3, you can omit this prebuilt and update the rules to 0.5 below after my cl lands. Please let me know so I can land 2142413004, thanks. +aluo, sorry, I didn't see your CL, no reason to stick to 0.3. I will rebase again yours
+jbudorick https://codereview.chromium.org/2270583003/diff/20001/third_party/android_sup... File third_party/android_support_test_runner/BUILD.gn (right): https://codereview.chromium.org/2270583003/diff/20001/third_party/android_sup... third_party/android_support_test_runner/BUILD.gn:20: android_java_prebuilt("rules_java") { On 2016/08/24 at 12:55:44, jbudorick wrote: > Until you've got a complete runner jar, what's this expected to do? How will this be used? This is an example, basically, the Rules are, in a way, replacing TestCase to provide activity context https://codereview.chromium.org/2266353003
On 2016/08/24 19:04:18, the real yoland wrote: > +jbudorick > > https://codereview.chromium.org/2270583003/diff/20001/third_party/android_sup... > File third_party/android_support_test_runner/BUILD.gn (right): > > https://codereview.chromium.org/2270583003/diff/20001/third_party/android_sup... > third_party/android_support_test_runner/BUILD.gn:20: > android_java_prebuilt("rules_java") { > On 2016/08/24 at 12:55:44, jbudorick wrote: > > Until you've got a complete runner jar, what's this expected to do? How will > this be used? > > This is an example, basically, the Rules are, in a way, replacing TestCase to > provide activity context https://codereview.chromium.org/2266353003 Meant the rules_java target itself.
On 2016/08/24 at 20:36:35, jbudorick wrote: > On 2016/08/24 19:04:18, the real yoland wrote: > > +jbudorick > > > > https://codereview.chromium.org/2270583003/diff/20001/third_party/android_sup... > > File third_party/android_support_test_runner/BUILD.gn (right): > > > > https://codereview.chromium.org/2270583003/diff/20001/third_party/android_sup... > > third_party/android_support_test_runner/BUILD.gn:20: > > android_java_prebuilt("rules_java") { > > On 2016/08/24 at 12:55:44, jbudorick wrote: > > > Until you've got a complete runner jar, what's this expected to do? How will > > this be used? > > > > This is an example, basically, the Rules are, in a way, replacing TestCase to > > provide activity context https://codereview.chromium.org/2266353003 > > Meant the rules_java target itself. hmm, "rules_java" is add in BUILD.gn file in the example: https://codereview.chromium.org/2266353003 To be able to do `import android.support.test.rule.ActivityTestRule;`, the target must depends on `rules_java`
Rebased and use aar prebuilt https://codereview.chromium.org/2270583003/diff/20001/third_party/android_sup... File third_party/android_support_test_runner/BUILD.gn (right): https://codereview.chromium.org/2270583003/diff/20001/third_party/android_sup... third_party/android_support_test_runner/BUILD.gn:20: android_java_prebuilt("rules_java") { On 2016/08/24 at 19:04:18, the real yoland wrote: > On 2016/08/24 at 12:55:44, jbudorick wrote: > > Until you've got a complete runner jar, what's this expected to do? How will this be used? > > This is an example, basically, the Rules are, in a way, replacing TestCase to provide activity context https://codereview.chromium.org/2266353003 Actually, just checked, there isn't a complete jar that merges runner.jar, rules.jar and exposeda-instrumentation-api.jar together
Description was changed from ========== Add exposed-instrumentation-api jar and rules jar BUG= ========== to ========== Add exposed-instrumentation-api jar and rules jar BUG=640116 ==========
10-line CL loves you too <3
Fine, fine. lgtm
The CQ bit was checked by yolandyan@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Add exposed-instrumentation-api jar and rules jar BUG=640116 ========== to ========== Add exposed-instrumentation-api jar and rules jar BUG=640116 Committed: https://crrev.com/9daee8af2bfb497448394ab3b5e7e76d81225bb1 Cr-Commit-Position: refs/heads/master@{#417696} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/9daee8af2bfb497448394ab3b5e7e76d81225bb1 Cr-Commit-Position: refs/heads/master@{#417696} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
