Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issue 2266353003: [EXAMPLE] Change WebView Layout Test to Android JUnit 4 style (Closed)

Created:
4 years, 4 months ago by the real yoland
Modified:
3 years, 11 months ago
CC:
android-webview-reviews_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change WebView Layout Test to Android JUnit 4 style DO NOT COMMIT THIS YET There are annotations in the code purely for the sake of showing the example BUG=640116

Patch Set 1 #

Patch Set 2 : Fix errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -41 lines) Patch
M android_webview/tools/system_webview_shell/BUILD.gn View 1 1 chunk +5 lines, -1 line 0 comments Download
A android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutActivityTestRule.java View 1 1 chunk +20 lines, -0 lines 0 comments Download
M android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java View 1 13 chunks +60 lines, -40 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
the real yoland
Do not need review yet, merely used as an example for showing Android JUnit4 style ...
4 years, 3 months ago (2016-08-23 16:12:25 UTC) #3
the real yoland
4 years, 3 months ago (2016-08-25 00:31:17 UTC) #4
the real yoland
4 years, 3 months ago (2016-08-26 21:08:01 UTC) #6
the real yoland
4 years, 3 months ago (2016-09-01 15:36:47 UTC) #8

          

Powered by Google App Engine
This is Rietveld 408576698