Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 2270583002: QUIC: Add packet_reader_yield_after_duration_milliseconds field trial param. (Closed)

Created:
4 years, 4 months ago by Zhongyi Shi
Modified:
4 years, 4 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org, ianswett
Base URL:
https://chromium.googlesource.com/chromium/src.git@new_master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

QUIC: Add packet_reader_yield_after_duration_milliseconds field trial param. When this field param is provided, QUIC packet reader will set yield_after_time_ packet_reader_yield_after_duration_milliseconds. Otherwise, set to 20ms. BUG=640074 Committed: https://crrev.com/6ba0f425818ef98dc2f82decae9d61e5d1d2edcd Cr-Commit-Position: refs/heads/master@{#413670}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -5 lines) Patch
M components/network_session_configurator/network_session_configurator.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M components/network_session_configurator/network_session_configurator_unittest.cc View 2 chunks +14 lines, -0 lines 0 comments Download
M net/http/http_network_session.h View 1 chunk +4 lines, -1 line 1 comment Download
M net/http/http_network_session.cc View 3 chunks +6 lines, -0 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/chromium/quic_stream_factory.cc View 2 chunks +2 lines, -1 line 0 comments Download
M net/quic/chromium/quic_stream_factory_test.cc View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Zhongyi Shi
rch: PTAL, thanks!
4 years, 4 months ago (2016-08-23 01:17:22 UTC) #4
Ryan Hamilton
Really well done! lgtm https://codereview.chromium.org/2270583002/diff/1/net/http/http_network_session.h File net/http/http_network_session.h (right): https://codereview.chromium.org/2270583002/diff/1/net/http/http_network_session.h#newcode165 net/http/http_network_session.h:165: // Specifies QUIC idle connection ...
4 years, 4 months ago (2016-08-23 02:21:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270583002/1
4 years, 4 months ago (2016-08-23 03:58:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-23 05:20:23 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-23 05:22:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6ba0f425818ef98dc2f82decae9d61e5d1d2edcd
Cr-Commit-Position: refs/heads/master@{#413670}

Powered by Google App Engine
This is Rietveld 408576698