Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: components/network_session_configurator/network_session_configurator_unittest.cc

Issue 2270583002: QUIC: Add packet_reader_yield_after_duration_milliseconds field trial param. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@new_master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/network_session_configurator/network_session_configurator_unittest.cc
diff --git a/components/network_session_configurator/network_session_configurator_unittest.cc b/components/network_session_configurator/network_session_configurator_unittest.cc
index fe724146c3ae9b07225f1daf0fc9b8c1186e1d18..0b11fb1e46adebddf94f35e0515a0f3755cc86f1 100644
--- a/components/network_session_configurator/network_session_configurator_unittest.cc
+++ b/components/network_session_configurator/network_session_configurator_unittest.cc
@@ -80,6 +80,8 @@ TEST_F(NetworkSessionConfiguratorTest, EnableQuicFromFieldTrialGroup) {
EXPECT_FALSE(params_.quic_close_sessions_on_ip_change);
EXPECT_EQ(net::kIdleConnectionTimeoutSeconds,
params_.quic_idle_connection_timeout_seconds);
+ EXPECT_EQ(net::kQuicYieldAfterDurationMilliseconds,
+ params_.quic_packet_reader_yield_after_duration_milliseconds);
EXPECT_FALSE(params_.quic_disable_preconnect_if_0rtt);
EXPECT_FALSE(params_.quic_migrate_sessions_on_network_change);
EXPECT_FALSE(params_.quic_migrate_sessions_early);
@@ -138,6 +140,18 @@ TEST_F(NetworkSessionConfiguratorTest,
EXPECT_EQ(300, params_.quic_idle_connection_timeout_seconds);
}
+TEST_F(NetworkSessionConfiguratorTest,
+ QuicPacketReaderYieldAfterDurationMillisecondsFieldTrialParams) {
+ std::map<std::string, std::string> field_trial_params;
+ field_trial_params["packet_reader_yield_after_duration_milliseconds"] = "10";
+ variations::AssociateVariationParams("QUIC", "Enabled", field_trial_params);
+ base::FieldTrialList::CreateFieldTrial("QUIC", "Enabled");
+
+ ParseFieldTrials();
+
+ EXPECT_EQ(10, params_.quic_packet_reader_yield_after_duration_milliseconds);
+}
+
TEST_F(NetworkSessionConfiguratorTest, QuicDisablePreConnectIfZeroRtt) {
std::map<std::string, std::string> field_trial_params;
field_trial_params["disable_preconnect_if_0rtt"] = "true";

Powered by Google App Engine
This is Rietveld 408576698