Clean up some discrepancies in the perf recipe configs

Clean up some discrepancies in the perf recipe configs

Remove "disable_tests" from all configs. Instead rely on "test_generators" and "test_spec_file" to determine whether generated tests should run.

Remove optional field "test_spec_file." The default is the name of the master. This means that tryserver.chromium.perf and chromium.perf.fyi will use their respective files instead of chromium.perf. This is a noop as those files either are empty or don't exist.

Change bisect testers to use the "tester" config instead of "builder." This is mostly a no-op since those configs were unified in previous CLs.

Remove the "perf-id" and "results-url" properties. I don't know if they were used for anything.


BUG=640287
Committed: https://chromium.googlesource.com/chromium/tools/build/+/05fb8c52d06b8c3892175979f3760f8116a4cfea

[dtu, 2016-08-24 01:04:21]

The CQ bit was checked by dtu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 01:04:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 01:06:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 01:06:36]

Dry run: Try jobs failed on following builders:
  Recipe Roll Downstream Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30d2e63e0abe2510)

[dtu, 2016-08-24 06:49:48]

Description was changed from

==========
(╯°□°)╯︵ ┻━┻


BUG=
==========

to

==========
Clean up some discrepancies in the perf recipe configs

Remove "disable_tests" from all configs. Instead rely on "test_generators" and
the test_spec_file to determine whether generated tests should run.

Change bisect testers to use the "tester" config instead of "builder." This is
mostly a no-op since those configs were unified in previous CLs.

Remove perf-id and results-url properties. They weren't used for anything
afaict.


BUG=640287
==========

[dtu, 2016-08-24 06:49:48]

dtu@chromium.org changed reviewers:
+ prasadv@chromium.org, robertocn@chromium.org

[dtu, 2016-08-24 06:54:56]

Description was changed from

==========
Clean up some discrepancies in the perf recipe configs

Remove "disable_tests" from all configs. Instead rely on "test_generators" and
the test_spec_file to determine whether generated tests should run.

Change bisect testers to use the "tester" config instead of "builder." This is
mostly a no-op since those configs were unified in previous CLs.

Remove perf-id and results-url properties. They weren't used for anything
afaict.


BUG=640287
==========

to

==========
Clean up some discrepancies in the perf recipe configs

Remove "disable_tests" from all configs. Instead rely on "test_generators" and
"test_spec_file" to determine whether generated tests should run.

Change bisect testers to use the "tester" config instead of "builder." This is
mostly a no-op since those configs were unified in previous CLs.

Remove the "perf-id" and "results-url" properties. I don't know if they were
used for anything.


BUG=640287
==========

[dtu, 2016-08-24 06:56:10]

https://codereview.chromium.org/2270563005/diff/20001/scripts/slave/recipe_mo...
File
scripts/slave/recipe_modules/auto_bisect/example.expected/android_arm64_bisector.json
(right):

https://codereview.chromium.org/2270563005/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/auto_bisect/example.expected/android_arm64_bisector.json:878:
"[TMP_BASE]/fake_checkout_tmp_1/testing/scripts/get_compile_targets.py",
All of the bots now query tryserver.chromium.perf.json for additional tests (and
compile targets for those tests) to run. Right now that file is empty, so these
steps should do nothing. This is more consistent with chromium.perf.

https://codereview.chromium.org/2270563005/diff/20001/scripts/slave/recipes/a...
File
scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json
(right):

https://codereview.chromium.org/2270563005/diff/20001/scripts/slave/recipes/a...
scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json:1:
[
The perf android bots don't use the chromium recipe, so we don't care about
this.

https://codereview.chromium.org/2270563005/diff/20001/scripts/slave/recipes/a...
File
scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json
(right):

https://codereview.chromium.org/2270563005/diff/20001/scripts/slave/recipes/a...
scripts/slave/recipes/android/perf.expected/get_perf_test_list_old_data.json:134:
"{\"buildername\": \"Android Nexus5 Perf (1)\", \"buildnumber\": 571,
\"mastername\": \"chromium.perf\", \"slavename\": \"slavename\",
\"target_platform\": \"android\"}"
Removal of the perf-id and results-url fields.

https://codereview.chromium.org/2270563005/diff/20001/scripts/slave/recipes/c...
File
scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_linux_fyi_perf_bisect.json
(right):

https://codereview.chromium.org/2270563005/diff/20001/scripts/slave/recipes/c...
scripts/slave/recipes/chromium.expected/full_tryserver_chromium_perf_linux_fyi_perf_bisect.json:1:
[
The bisect bots don't run the chromium recipe, so we don't care about these
expectations changes.

[dtu, 2016-08-24 19:15:14]

The CQ bit was checked by dtu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 19:15:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dtu, 2016-08-24 19:16:02]

Description was changed from

==========
Clean up some discrepancies in the perf recipe configs

Remove "disable_tests" from all configs. Instead rely on "test_generators" and
"test_spec_file" to determine whether generated tests should run.

Change bisect testers to use the "tester" config instead of "builder." This is
mostly a no-op since those configs were unified in previous CLs.

Remove the "perf-id" and "results-url" properties. I don't know if they were
used for anything.


BUG=640287
==========

to

==========
Clean up some discrepancies in the perf recipe configs

Remove "disable_tests" from all configs. Instead rely on "test_generators" and
"test_spec_file" to determine whether generated tests should run.

Remove optional field "test_spec_file." The default is the name of the master.
This means that tryserver.chromium.perf and chromium.perf.fyi will use their
respective files instead of chromium.perf. This is a noop as those files either
are empty or don't exist.

Change bisect testers to use the "tester" config instead of "builder." This is
mostly a no-op since those configs were unified in previous CLs.

Remove the "perf-id" and "results-url" properties. I don't know if they were
used for anything.


BUG=640287
==========

[commit-bot: I haz the power, 2016-08-24 19:19:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 19:19:36]

Dry run: This issue passed the CQ dry run.

[dtu, 2016-08-30 18:14:02]

Suuup

[RobertoCN, 2016-08-30 21:08:02]

lGtm, I guess.

https://codereview.chromium.org/2270563005/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py (right):

https://codereview.chromium.org/2270563005/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py:35: def
_AddTestSpec(name, perf_id, platform, parent_buildername=None, target_bits=64):
Is this line long, or is my browser wrapping it wrongly?

https://codereview.chromium.org/2270563005/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/steps.py (right):

https://codereview.chromium.org/2270563005/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/steps.py:544: def __init__(self,
perf_id, platform, target_bits, max_battery_temp=350,
Magic number.

[dtu, 2016-08-31 08:36:34]

https://codereview.chromium.org/2270563005/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py (right):

https://codereview.chromium.org/2270563005/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/chromium_perf_fyi.py:35: def
_AddTestSpec(name, perf_id, platform, parent_buildername=None, target_bits=64):
On 2016/08/30 21:08:01, RobertoCN wrote:
> Is this line long, or is my browser wrapping it wrongly?

Done.

https://codereview.chromium.org/2270563005/diff/20001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromium_tests/steps.py (right):

https://codereview.chromium.org/2270563005/diff/20001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromium_tests/steps.py:544: def __init__(self,
perf_id, platform, target_bits, max_battery_temp=350,
On 2016/08/30 21:08:01, RobertoCN wrote:
> Magic number.

Acknowledged. I don't have an explanation I can add for this value; it was the
default value picked by Randy. It's 35.0 Celsius.

[dtu, 2016-08-31 08:36:42]

The CQ bit was checked by dtu@chromium.org

[dtu, 2016-08-31 08:36:43]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertocn@chromium.org
Link to the patchset: https://codereview.chromium.org/2270563005/#ps40001
(title: "lint")

[commit-bot: I haz the power, 2016-08-31 08:36:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 08:44:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 08:44:56]

Try jobs failed on following builders:
  Build Presubmit on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/30f890096ca1e410)

[dtu, 2016-08-31 16:50:25]

dtu@chromium.org changed reviewers:
+ stip@chromium.org

[dtu, 2016-08-31 16:50:26]

+stip, OWNERS

[ghost stip (do not use), 2016-09-02 00:57:45]

whoosh. I would have like this CL broken down into a few smaller CLs. rs-lgtm

[dtu, 2016-09-02 18:46:27]

On 2016/09/02 00:57:45, stip wrote:
> whoosh. I would have like this CL broken down into a few smaller CLs. rs-lgtm

it's not a big CL, i promise! it's misleading because there's a lot of generated
files.

[dtu, 2016-09-02 18:46:50]

The CQ bit was checked by dtu@chromium.org

[dtu, 2016-09-02 18:46:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertocn@chromium.org, stip@chromium.org
Link to the patchset: https://codereview.chromium.org/2270563005/#ps60001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-09-02 18:47:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 18:52:06]

Description was changed from

==========
Clean up some discrepancies in the perf recipe configs

Remove "disable_tests" from all configs. Instead rely on "test_generators" and
"test_spec_file" to determine whether generated tests should run.

Remove optional field "test_spec_file." The default is the name of the master.
This means that tryserver.chromium.perf and chromium.perf.fyi will use their
respective files instead of chromium.perf. This is a noop as those files either
are empty or don't exist.

Change bisect testers to use the "tester" config instead of "builder." This is
mostly a no-op since those configs were unified in previous CLs.

Remove the "perf-id" and "results-url" properties. I don't know if they were
used for anything.


BUG=640287
==========

to

==========
Clean up some discrepancies in the perf recipe configs

Remove "disable_tests" from all configs. Instead rely on "test_generators" and
"test_spec_file" to determine whether generated tests should run.

Remove optional field "test_spec_file." The default is the name of the master.
This means that tryserver.chromium.perf and chromium.perf.fyi will use their
respective files instead of chromium.perf. This is a noop as those files either
are empty or don't exist.

Change bisect testers to use the "tester" config instead of "builder." This is
mostly a no-op since those configs were unified in previous CLs.

Remove the "perf-id" and "results-url" properties. I don't know if they were
used for anything.


BUG=640287

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/05fb8c52d06b8c389217...
==========

[commit-bot: I haz the power, 2016-09-02 18:52:07]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/tools/build/+/05fb8c52d06b8c389217...