scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py - Issue 2270563005: Clean up some discrepancies in the perf recipe configs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py

Issue 2270563005: Clean up some discrepancies in the perf recipe configs (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master

Patch Set: Rebase. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/chromium_tests/steps.py ('k') | scripts/slave/recipes/android/perf.expected/full_chromium_perf_Android_Galaxy_S5_Perf__1_.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py

diff --git a/scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py b/scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py

index 6d451bfe68d9f31dbd807ba45f756e28877ad43d..f7f88bc25d33defe58857a0e521f4648340fe7e3 100644

--- a/scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py

+++ b/scripts/slave/recipe_modules/chromium_tests/tryserver_chromium_perf.py

@@ -31,17 +31,14 @@ def tryserver_chromium_perf(c):

def _AddBuildSpec(name, platform, target_bits=64):

+ # We run sizes with no perf_id for perf tryjobs. http://crbug.com/610772

SPEC['builders'][name] = chromium_perf.BuildSpec(

'tryserver_chromium_perf', None, platform, target_bits)

def _AddTestSpec(name, platform, target_bits=64):

- # TODO(dtu): Change this to TestSpec after try job builds are all offloaded

- # to builders.

- spec = chromium_perf.BuildSpec(

- 'tryserver_chromium_perf', None, platform, target_bits)

- del spec['tests']

- SPEC['builders'][name] = spec

+ SPEC['builders'][name] = chromium_perf.TestSpec(

+ 'tryserver_chromium_perf', platform, target_bits)

_AddBuildSpec('win_perf_bisect_builder', 'win', target_bits=32)