Move ash::DisplayInfo to ui

Move ash::DisplayInfo to ui

To permit reusing portions of ash/display in both mus and ash, we need
to move some code to ui. Start this process by relocating
ash/common/display/display_info.* as it is the root of the inclusion
dependency tree.

BUG=581462
Committed: https://crrev.com/259c01882447ce69f9e65fa526bb3789822a18c2
Cr-Commit-Position: refs/heads/master@{#415395}

[rjkroege, 2016-08-23 00:03:22]

rjkroege@chromium.org changed reviewers:
+ oshima@chromium.org

[rjkroege, 2016-08-23 00:03:24]

ptal. More moving.

[rjkroege, 2016-08-23 00:04:26]

The CQ bit was checked by rjkroege@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-23 00:05:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 00:17:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 00:17:07]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[oshima, 2016-08-24 13:04:27]

On 2016/08/23 00:03:24, rjkroege wrote:
> ptal. More moving.

Test failure looks real. Can you take a look?

[rjkroege, 2016-08-24 19:02:45]

The CQ bit was checked by rjkroege@chromium.org to run a CQ dry run

[rjkroege, 2016-08-24 19:03:09]

oops. I forgot to delete one line of debugging code. Fixed.

PTAL.

[commit-bot: I haz the power, 2016-08-24 19:04:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 19:08:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 19:09:00]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rjkroege, 2016-08-24 21:40:01]

The CQ bit was checked by rjkroege@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-24 21:40:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 21:49:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 21:49:01]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hshi, 2016-08-25 00:43:41]

hshi@google.com changed reviewers:
+ hshi@google.com

[hshi, 2016-08-25 00:43:42]

https://codereview.chromium.org/2270553002/diff/40001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2270553002/diff/40001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:36: }
nit: alphabetically "namespace ui" should appear above "namespace views"

[rjkroege, 2016-08-25 21:42:16]

ptal

https://codereview.chromium.org/2270553002/diff/40001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2270553002/diff/40001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:36: }
On 2016/08/25 00:43:42, hshi wrote:
> nit: alphabetically "namespace ui" should appear above "namespace views"

Done.

[rjkroege, 2016-08-25 21:42:23]

The CQ bit was checked by rjkroege@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-25 21:42:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 23:27:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-25 23:27:31]

Dry run: This issue passed the CQ dry run.

[oshima, 2016-08-26 21:47:53]

lgtm

https://codereview.chromium.org/2270553002/diff/60001/ash/content/display/scr...
File ash/content/display/screen_orientation_controller_chromeos_unittest.cc
(right):

https://codereview.chromium.org/2270553002/diff/60001/ash/content/display/scr...
ash/content/display/screen_orientation_controller_chromeos_unittest.cc:640: //
so
nit: format

https://codereview.chromium.org/2270553002/diff/60001/ash/display/window_tree...
File ash/display/window_tree_host_manager.h (right):

https://codereview.chromium.org/2270553002/diff/60001/ash/display/window_tree...
ash/display/window_tree_host_manager.h:45: }
Remove this?

https://codereview.chromium.org/2270553002/diff/60001/ash/host/ash_window_tre...
File ash/host/ash_window_tree_host_unified.h (right):

https://codereview.chromium.org/2270553002/diff/60001/ash/host/ash_window_tre...
ash/host/ash_window_tree_host_unified.h:15: class ManagedDisplayInfo;
remove this?

[kylechar, 2016-08-29 16:01:31]

kylechar@chromium.org changed reviewers:
+ kylechar@chromium.org

[kylechar, 2016-08-29 16:01:33]

https://codereview.chromium.org/2270553002/diff/60001/ui/display/manager/mana...
File ui/display/manager/managed_display_info.h (right):

https://codereview.chromium.org/2270553002/diff/60001/ui/display/manager/mana...
ui/display/manager/managed_display_info.h:22: namespace ui {
Should this be namespace display? It seems like all new code in ui/display is
going there and would make sense to eventually move everything in ui/display
into the same namespace.

[rjkroege, 2016-08-29 22:21:58]

rjkroege@chromium.org changed reviewers:
+ reveman@chromium.org, rockot@chromium.org, rogerta@chromium.org,
stevenjb@chromium.org

[rjkroege, 2016-08-29 22:22:00]

comments addressed. ptal.

And:

reveman@ owners for components/exo/*
stevenjb@ owners for chrome/browser/ui/webui/options/chromeos
rockot@ owners for review for chrome/browser/extensions/*
rogerta@ owners review for chrome/browser/signin/*

https://codereview.chromium.org/2270553002/diff/60001/ash/content/display/scr...
File ash/content/display/screen_orientation_controller_chromeos_unittest.cc
(right):

https://codereview.chromium.org/2270553002/diff/60001/ash/content/display/scr...
ash/content/display/screen_orientation_controller_chromeos_unittest.cc:640: //
so
On 2016/08/26 21:47:53, oshima wrote:
> nit: format

Done.

https://codereview.chromium.org/2270553002/diff/60001/ash/display/window_tree...
File ash/display/window_tree_host_manager.h (right):

https://codereview.chromium.org/2270553002/diff/60001/ash/display/window_tree...
ash/display/window_tree_host_manager.h:45: }
On 2016/08/26 21:47:53, oshima wrote:
> Remove this?

Done.

https://codereview.chromium.org/2270553002/diff/60001/ash/host/ash_window_tre...
File ash/host/ash_window_tree_host_unified.h (right):

https://codereview.chromium.org/2270553002/diff/60001/ash/host/ash_window_tre...
ash/host/ash_window_tree_host_unified.h:15: class ManagedDisplayInfo;
On 2016/08/26 21:47:53, oshima wrote:
> remove this?

Done.

https://codereview.chromium.org/2270553002/diff/60001/ui/display/manager/mana...
File ui/display/manager/managed_display_info.h (right):

https://codereview.chromium.org/2270553002/diff/60001/ui/display/manager/mana...
ui/display/manager/managed_display_info.h:22: namespace ui {
On 2016/08/29 16:01:33, kylechar wrote:
> Should this be namespace display? It seems like all new code in ui/display is
> going there and would make sense to eventually move everything in ui/display
> into the same namespace.

Done.

[stevenjb, 2016-08-29 22:23:39]

c/b/ui/webui lgtm

[reveman, 2016-08-29 22:24:18]

components/exo lgtm

[Ken Rockot(use gerrit already), 2016-08-30 01:01:49]

lgtm

[kylechar, 2016-08-30 12:23:50]

Description was changed from

==========
Move ash::DisplayInfo to ui

To permit reusing portions of ash/display in both mus and ash, we need
to move some code to ui. Start this process by relocating
ash/common/display/display_info.* as it is the root of the inclusion
dependency tree.

BUG=581462
==========

to

==========
Move ash::DisplayInfo to ui

To permit reusing portions of ash/display in both mus and ash, we need
to move some code to ui. Start this process by relocating
ash/common/display/display_info.* as it is the root of the inclusion
dependency tree.

BUG=581462
==========

[kylechar, 2016-08-30 12:23:50]

kylechar@chromium.org changed reviewers:
- kylechar@chromium.org

[Roger Tawa OOO till Jul 10th, 2016-08-30 15:48:46]

lgtm chrome/browser/signin

[hshi, 2016-08-30 17:47:49]

lgtm

[rjkroege, 2016-08-30 17:48:29]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2016-08-30 17:48:30]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2270553002/#ps80001
(title: "review comments")

[commit-bot: I haz the power, 2016-08-30 17:49:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 17:53:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 17:53:57]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[rjkroege, 2016-08-30 18:04:18]

The CQ bit was checked by rjkroege@chromium.org

[rjkroege, 2016-08-30 18:04:19]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
stevenjb@chromium.org, rogerta@chromium.org, oshima@chromium.org,
hshi@google.com, reveman@chromium.org
Link to the patchset: https://codereview.chromium.org/2270553002/#ps100001
(title: "rebased")

[commit-bot: I haz the power, 2016-08-30 18:04:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 19:30:10]

Description was changed from

==========
Move ash::DisplayInfo to ui

To permit reusing portions of ash/display in both mus and ash, we need
to move some code to ui. Start this process by relocating
ash/common/display/display_info.* as it is the root of the inclusion
dependency tree.

BUG=581462
==========

to

==========
Move ash::DisplayInfo to ui

To permit reusing portions of ash/display in both mus and ash, we need
to move some code to ui. Start this process by relocating
ash/common/display/display_info.* as it is the root of the inclusion
dependency tree.

BUG=581462
==========

[commit-bot: I haz the power, 2016-08-30 19:30:13]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-08-30 19:32:52]

Description was changed from

==========
Move ash::DisplayInfo to ui

To permit reusing portions of ash/display in both mus and ash, we need
to move some code to ui. Start this process by relocating
ash/common/display/display_info.* as it is the root of the inclusion
dependency tree.

BUG=581462
==========

to

==========
Move ash::DisplayInfo to ui

To permit reusing portions of ash/display in both mus and ash, we need
to move some code to ui. Start this process by relocating
ash/common/display/display_info.* as it is the root of the inclusion
dependency tree.

BUG=581462

Committed: https://crrev.com/259c01882447ce69f9e65fa526bb3789822a18c2
Cr-Commit-Position: refs/heads/master@{#415395}
==========

[commit-bot: I haz the power, 2016-08-30 19:32:54]

Patchset 6 (id:??) landed as
https://crrev.com/259c01882447ce69f9e65fa526bb3789822a18c2
Cr-Commit-Position: refs/heads/master@{#415395}