cc: Remove the software compositing bool from PrepareTextureMailbox

cc: Remove the software compositing bool from PrepareTextureMailbox

A quick followup after https://codereview.chromium.org/2267993002/ that
deletes the now-unused parameter.

Since clients determine if they should give cc a GPU or software
mailbox based on the GL context, we no longer need this bool parameter
in PrepareTextureMailbox. Also we don't need the RendererCapabilities
field anymore.

In changing one Canvas2DLayerBridge test to lose the GL context then
call PrepareTextureMailbox, I uncovered that this would cause DCHECKs
in the method to fail since isAccelerated() returns false on the first
call when the context is lost (but does not return false if
PrepareTextureMailbox happens with a non-lost context at least once
beforehand). So I left a call to prepareSurfaceForPaintingIfNeeded() to
work around the issue with a TODO. It seems like isAccelerated() should
just go away or something but I'm not sure.

R=junov@chromium.org, kbr@chromium.org, piman@chromium.org
TBR=pfeldman
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/4d0dd80db68c7aa1a43d6463d828db77ae4b0229
Cr-Commit-Position: refs/heads/master@{#413854}

[danakj, 2016-08-22 23:48:44]

Description was changed from

==========
cc: Remove the software compositing bool from PrepareTextureMailbox

A small followup after https://codereview.chromium.org/2267993002/ that
deletes the now-unused parameter.

Since clients determine if they should give cc a GPU or software
mailbox based on the GL context, we no longer need this bool parameter
in PrepareTextureMailbox. Also we don't need the RendererCapabilities
field anymore.

In changing one Canvas2DLayerBridge test to lose the GL context then
call PrepareTextureMailbox, I uncovered that this would cause DCHECKs
in the method to fail since isAccelerated() returns false on the first
call when the context is lost (but does not return false if
PrepareTextureMailbox happens with a non-lost context at least once
beforehand). So I left a call to prepareSurfaceForPaintingIfNeeded() to
work around the issue with a TODO. It seems like isAccelerated() should
just go away or something but I'm not sure.

R=junov@chromium.org, kbr@chromium.org, piman@chromium.org
BUG=606056
==========

to

==========
cc: Remove the software compositing bool from PrepareTextureMailbox

A small followup after https://codereview.chromium.org/2267993002/ that
deletes the now-unused parameter.

Since clients determine if they should give cc a GPU or software
mailbox based on the GL context, we no longer need this bool parameter
in PrepareTextureMailbox. Also we don't need the RendererCapabilities
field anymore.

In changing one Canvas2DLayerBridge test to lose the GL context then
call PrepareTextureMailbox, I uncovered that this would cause DCHECKs
in the method to fail since isAccelerated() returns false on the first
call when the context is lost (but does not return false if
PrepareTextureMailbox happens with a non-lost context at least once
beforehand). So I left a call to prepareSurfaceForPaintingIfNeeded() to
work around the issue with a TODO. It seems like isAccelerated() should
just go away or something but I'm not sure.

R=junov@chromium.org, kbr@chromium.org, piman@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-08-22 23:48:46]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-08-22 23:48:57]

Description was changed from

==========
cc: Remove the software compositing bool from PrepareTextureMailbox

A small followup after https://codereview.chromium.org/2267993002/ that
deletes the now-unused parameter.

Since clients determine if they should give cc a GPU or software
mailbox based on the GL context, we no longer need this bool parameter
in PrepareTextureMailbox. Also we don't need the RendererCapabilities
field anymore.

In changing one Canvas2DLayerBridge test to lose the GL context then
call PrepareTextureMailbox, I uncovered that this would cause DCHECKs
in the method to fail since isAccelerated() returns false on the first
call when the context is lost (but does not return false if
PrepareTextureMailbox happens with a non-lost context at least once
beforehand). So I left a call to prepareSurfaceForPaintingIfNeeded() to
work around the issue with a TODO. It seems like isAccelerated() should
just go away or something but I'm not sure.

R=junov@chromium.org, kbr@chromium.org, piman@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove the software compositing bool from PrepareTextureMailbox

A quick followup after https://codereview.chromium.org/2267993002/ that
deletes the now-unused parameter.

Since clients determine if they should give cc a GPU or software
mailbox based on the GL context, we no longer need this bool parameter
in PrepareTextureMailbox. Also we don't need the RendererCapabilities
field anymore.

In changing one Canvas2DLayerBridge test to lose the GL context then
call PrepareTextureMailbox, I uncovered that this would cause DCHECKs
in the method to fail since isAccelerated() returns false on the first
call when the context is lost (but does not return false if
PrepareTextureMailbox happens with a non-lost context at least once
beforehand). So I left a call to prepareSurfaceForPaintingIfNeeded() to
work around the issue with a TODO. It seems like isAccelerated() should
just go away or something but I'm not sure.

R=junov@chromium.org, kbr@chromium.org, piman@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-08-22 23:49:31]

piman: please review*
kbr: platform/graphics/gpu OWNERS
junov: platform/graphics OWNERS

[commit-bot: I haz the power, 2016-08-22 23:49:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 00:14:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 00:14:41]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[danakj, 2016-08-23 00:20:25]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[Ken Russell (switch to Gerrit), 2016-08-23 00:20:28]

LGTM. Thanks for cleaning this up.

[commit-bot: I haz the power, 2016-08-23 00:22:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-08-23 00:52:40]

lgtm

https://codereview.chromium.org/2270533002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
(right):

https://codereview.chromium.org/2270533002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp:787: return
false;
Nit: this code is dupe of the same right below.

[danakj, 2016-08-23 00:54:44]

https://codereview.chromium.org/2270533002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp
(right):

https://codereview.chromium.org/2270533002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/Canvas2DLayerBridge.cpp:787: return
false;
On 2016/08/23 00:52:40, piman wrote:
> Nit: this code is dupe of the same right below.

Oops thanks, bad merging.

[danakj, 2016-08-23 01:02:06]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-08-23 01:02:55]

junov: just in case it's lost, this one needs your eye as well, thank you!

[commit-bot: I haz the power, 2016-08-23 01:03:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 04:25:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-23 04:25:41]

Dry run: This issue passed the CQ dry run.

[Justin Novosad, 2016-08-23 20:56:13]

On 2016/08/23 01:02:55, danakj wrote:
> junov: just in case it's lost, this one needs your eye as well, thank you!

lgtm

[danakj, 2016-08-23 22:02:56]

Description was changed from

==========
cc: Remove the software compositing bool from PrepareTextureMailbox

A quick followup after https://codereview.chromium.org/2267993002/ that
deletes the now-unused parameter.

Since clients determine if they should give cc a GPU or software
mailbox based on the GL context, we no longer need this bool parameter
in PrepareTextureMailbox. Also we don't need the RendererCapabilities
field anymore.

In changing one Canvas2DLayerBridge test to lose the GL context then
call PrepareTextureMailbox, I uncovered that this would cause DCHECKs
in the method to fail since isAccelerated() returns false on the first
call when the context is lost (but does not return false if
PrepareTextureMailbox happens with a non-lost context at least once
beforehand). So I left a call to prepareSurfaceForPaintingIfNeeded() to
work around the issue with a TODO. It seems like isAccelerated() should
just go away or something but I'm not sure.

R=junov@chromium.org, kbr@chromium.org, piman@chromium.org
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove the software compositing bool from PrepareTextureMailbox

A quick followup after https://codereview.chromium.org/2267993002/ that
deletes the now-unused parameter.

Since clients determine if they should give cc a GPU or software
mailbox based on the GL context, we no longer need this bool parameter
in PrepareTextureMailbox. Also we don't need the RendererCapabilities
field anymore.

In changing one Canvas2DLayerBridge test to lose the GL context then
call PrepareTextureMailbox, I uncovered that this would cause DCHECKs
in the method to fail since isAccelerated() returns false on the first
call when the context is lost (but does not return false if
PrepareTextureMailbox happens with a non-lost context at least once
beforehand). So I left a call to prepareSurfaceForPaintingIfNeeded() to
work around the issue with a TODO. It seems like isAccelerated() should
just go away or something but I'm not sure.

R=junov@chromium.org, kbr@chromium.org, piman@chromium.org
TBR=pfeldman
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[danakj, 2016-08-23 22:02:56]

danakj@chromium.org changed reviewers:
+ pfeldman@chromium.org

[danakj, 2016-08-23 22:03:09]

+pfeldman for components/test_runner/ (TBR)

[danakj, 2016-08-23 22:03:16]

The CQ bit was checked by danakj@chromium.org

[danakj, 2016-08-23 22:03:16]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2270533002/#ps40001
(title: "remove-prepare-mailbox-param: bad-merge")

[commit-bot: I haz the power, 2016-08-23 22:04:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-23 22:10:21]

Description was changed from

==========
cc: Remove the software compositing bool from PrepareTextureMailbox

A quick followup after https://codereview.chromium.org/2267993002/ that
deletes the now-unused parameter.

Since clients determine if they should give cc a GPU or software
mailbox based on the GL context, we no longer need this bool parameter
in PrepareTextureMailbox. Also we don't need the RendererCapabilities
field anymore.

In changing one Canvas2DLayerBridge test to lose the GL context then
call PrepareTextureMailbox, I uncovered that this would cause DCHECKs
in the method to fail since isAccelerated() returns false on the first
call when the context is lost (but does not return false if
PrepareTextureMailbox happens with a non-lost context at least once
beforehand). So I left a call to prepareSurfaceForPaintingIfNeeded() to
work around the issue with a TODO. It seems like isAccelerated() should
just go away or something but I'm not sure.

R=junov@chromium.org, kbr@chromium.org, piman@chromium.org
TBR=pfeldman
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove the software compositing bool from PrepareTextureMailbox

A quick followup after https://codereview.chromium.org/2267993002/ that
deletes the now-unused parameter.

Since clients determine if they should give cc a GPU or software
mailbox based on the GL context, we no longer need this bool parameter
in PrepareTextureMailbox. Also we don't need the RendererCapabilities
field anymore.

In changing one Canvas2DLayerBridge test to lose the GL context then
call PrepareTextureMailbox, I uncovered that this would cause DCHECKs
in the method to fail since isAccelerated() returns false on the first
call when the context is lost (but does not return false if
PrepareTextureMailbox happens with a non-lost context at least once
beforehand). So I left a call to prepareSurfaceForPaintingIfNeeded() to
work around the issue with a TODO. It seems like isAccelerated() should
just go away or something but I'm not sure.

R=junov@chromium.org, kbr@chromium.org, piman@chromium.org
TBR=pfeldman
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[commit-bot: I haz the power, 2016-08-23 22:10:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-23 22:13:35]

Description was changed from

==========
cc: Remove the software compositing bool from PrepareTextureMailbox

A quick followup after https://codereview.chromium.org/2267993002/ that
deletes the now-unused parameter.

Since clients determine if they should give cc a GPU or software
mailbox based on the GL context, we no longer need this bool parameter
in PrepareTextureMailbox. Also we don't need the RendererCapabilities
field anymore.

In changing one Canvas2DLayerBridge test to lose the GL context then
call PrepareTextureMailbox, I uncovered that this would cause DCHECKs
in the method to fail since isAccelerated() returns false on the first
call when the context is lost (but does not return false if
PrepareTextureMailbox happens with a non-lost context at least once
beforehand). So I left a call to prepareSurfaceForPaintingIfNeeded() to
work around the issue with a TODO. It seems like isAccelerated() should
just go away or something but I'm not sure.

R=junov@chromium.org, kbr@chromium.org, piman@chromium.org
TBR=pfeldman
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
cc: Remove the software compositing bool from PrepareTextureMailbox

A quick followup after https://codereview.chromium.org/2267993002/ that
deletes the now-unused parameter.

Since clients determine if they should give cc a GPU or software
mailbox based on the GL context, we no longer need this bool parameter
in PrepareTextureMailbox. Also we don't need the RendererCapabilities
field anymore.

In changing one Canvas2DLayerBridge test to lose the GL context then
call PrepareTextureMailbox, I uncovered that this would cause DCHECKs
in the method to fail since isAccelerated() returns false on the first
call when the context is lost (but does not return false if
PrepareTextureMailbox happens with a non-lost context at least once
beforehand). So I left a call to prepareSurfaceForPaintingIfNeeded() to
work around the issue with a TODO. It seems like isAccelerated() should
just go away or something but I'm not sure.

R=junov@chromium.org, kbr@chromium.org, piman@chromium.org
TBR=pfeldman
BUG=606056
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/4d0dd80db68c7aa1a43d6463d828db77ae4b0229
Cr-Commit-Position: refs/heads/master@{#413854}
==========

[commit-bot: I haz the power, 2016-08-23 22:13:37]

Patchset 3 (id:??) landed as
https://crrev.com/4d0dd80db68c7aa1a43d6463d828db77ae4b0229
Cr-Commit-Position: refs/heads/master@{#413854}