Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2270433002:
Remove old Clang plugin flags. (Closed)
DescriptionRemove old Clang plugin flags.
These flags are on-by-default and no longer passed in as of
https://codereview.chromium.org/2292173002
Committed: https://crrev.com/f0563f0ccdfd6e74b0cd4d59b2b900cd69fff2c3
Cr-Commit-Position: refs/heads/master@{#415719}
Patch Set 1 #Patch Set 2 : Last dance #
Total comments: 2
Patch Set 3 : Last last dance #Messages
Total messages: 27 (14 generated)
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thestig@chromium.org changed reviewers: + thakis@chromium.org
The plugin is bundled with clang binaries. So if you remove this flag, this will become active the next time we roll clang -- and if something in pdf doesn't pass the style check, that means that might block the next clang roll. Rolling clang is already pretty hard, so we prefer to not add blockers like this. Instead, we usually do: 1. Turn on flag everywhere (turn on flag here: https://cs.chromium.org/chromium/src/build/config/clang/BUILD.gn?q=add-plugin... 2. Then land a change to the plugin that makes the flag a no-op, e.g. https://codereview.chromium.org/2267713003/ 3. Wait for clang roll 4. Remove flag added in 1 again 5. Remove flag from plugin That way, none of the steps blocks a clang roll.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Ack. Will do the dance.
On 2016/08/22 22:03:19, Lei Zhang wrote: > Ack. Will do the dance. 1) https://codereview.chromium.org/2270463003/ 2) https://codereview.chromium.org/2268203002/ Can you ping me after the next Clang roll and I'll continue with (4) and (5)?
The CQ bit was checked by thestig@chromium.org to run a CQ dry run
Ready for review.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm; hopefully the roll will stick https://codereview.chromium.org/2270433002/diff/20001/tools/clang/plugins/Fin... File tools/clang/plugins/FindBadConstructsAction.cpp (right): https://codereview.chromium.org/2270433002/diff/20001/tools/clang/plugins/Fin... tools/clang/plugins/FindBadConstructsAction.cpp:58: // the build no longer passes it in. If you have the branch around you made this CL on, could you remove this and the one below too?
https://codereview.chromium.org/2270433002/diff/20001/tools/clang/plugins/Fin... File tools/clang/plugins/FindBadConstructsAction.cpp (right): https://codereview.chromium.org/2270433002/diff/20001/tools/clang/plugins/Fin... tools/clang/plugins/FindBadConstructsAction.cpp:58: // the build no longer passes it in. On 2016/08/31 17:37:58, Nico wrote: > If you have the branch around you made this CL on, could you remove this and the > one below too? Done.
The CQ bit was checked by thestig@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from thakis@chromium.org Link to the patchset: https://codereview.chromium.org/2270433002/#ps40001 (title: "Last last dance")
Description was changed from ========== Remove enforce-in-pdf Clang plugin flag. ========== to ========== Remove old Clang plugin flags. These flags are on-by-default and no longer passed in as of https://codereview.chromium.org/2292173002 ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm++ I updated your CL description.
The CQ bit was unchecked by thestig@chromium.org
The CQ bit was checked by thestig@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove old Clang plugin flags. These flags are on-by-default and no longer passed in as of https://codereview.chromium.org/2292173002 ========== to ========== Remove old Clang plugin flags. These flags are on-by-default and no longer passed in as of https://codereview.chromium.org/2292173002 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Remove old Clang plugin flags. These flags are on-by-default and no longer passed in as of https://codereview.chromium.org/2292173002 ========== to ========== Remove old Clang plugin flags. These flags are on-by-default and no longer passed in as of https://codereview.chromium.org/2292173002 Committed: https://crrev.com/f0563f0ccdfd6e74b0cd4d59b2b900cd69fff2c3 Cr-Commit-Position: refs/heads/master@{#415719} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/f0563f0ccdfd6e74b0cd4d59b2b900cd69fff2c3 Cr-Commit-Position: refs/heads/master@{#415719} |
