Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 227043006: Fixed Skia compilation error with strict clang. (Closed)

Created:
6 years, 8 months ago by Krzysztof Olczyk
Modified:
6 years, 8 months ago
Reviewers:
Sergey Berezin, hcm, reed1
CC:
skia-review_googlegroups.com, Mostyn Bramley-Moore
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fixed Skia compilation error with strict clang. BUG=skia: Committed: http://code.google.com/p/skia/source/detail?r=14071

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M src/utils/SkParseColor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Krzysztof Olczyk
Hi reed and Sergey, could you please re-lgtm this code as I've resubmitted https://codereview.chromium.org/207443008/ which ...
6 years, 8 months ago (2014-04-07 09:51:15 UTC) #1
reed1
lgtm
6 years, 8 months ago (2014-04-07 12:53:32 UTC) #2
reed1
heather, can you review the AUTHORS file
6 years, 8 months ago (2014-04-07 12:54:04 UTC) #3
hcm
On 2014/04/07 12:54:04, reed1 wrote: > heather, can you review the AUTHORS file lgtm, thanks!
6 years, 8 months ago (2014-04-07 12:55:17 UTC) #4
Krzysztof Olczyk
The CQ bit was checked by kolczyk@opera.com
6 years, 8 months ago (2014-04-07 12:56:10 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/kolczyk@opera.com/227043006/1
6 years, 8 months ago (2014-04-07 12:56:19 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-07 13:12:51 UTC) #7
Message was sent while issue was closed. 
Change committed as 14071

Powered by Google App Engine
This is Rietveld 408576698