Fixed Skia compilation error with strict clang.

Fixed Skia compilation error with strict clang.

BUG=

[Krzysztof Olczyk, 2014-03-21 10:06:42]

Hi reed,

could you please take a look at this simple change to make this ifdeffed piece
of code compile with clang?

[Krzysztof Olczyk, 2014-03-21 11:32:30]

Hi reed,

could you please take a look at this simple change to make this ifdeffed piece
of code compile with clang?

[reed1, 2014-03-21 15:55:55]

your change reverses the sense of the test. The code wants to assert that
FindColor failed, which it indicates by returning NULL. Your change will assert
that the test should succeed. I think the fix for the compiler is to replace
"false" with NULL

https://codereview.chromium.org/207443008/diff/1/utils/SkParseColor.cpp
File utils/SkParseColor.cpp (left):

https://codereview.chromium.org/207443008/diff/1/utils/SkParseColor.cpp#oldco...
utils/SkParseColor.cpp:516: SkASSERT(FindColor(bad, &result) == false);
I think the right fix is

FindColor(...) == NULL

[hcm, 2014-03-21 16:01:22]

On 2014/03/21 15:56:54, reed1 wrote:

I verified Opera has signed the Google Corporate CLA but we do need them to add
a line to the Skia trunk/AUTHORS file to get the CL to go through with the new
checks in place.  (It should pass the checks if added as a part of this CL when
ready to commit)

[Krzysztof Olczyk, 2014-03-24 07:45:17]

Yes, of course. Fixed that.

https://codereview.chromium.org/207443008/diff/1/utils/SkParseColor.cpp
File utils/SkParseColor.cpp (left):

https://codereview.chromium.org/207443008/diff/1/utils/SkParseColor.cpp#oldco...
utils/SkParseColor.cpp:516: SkASSERT(FindColor(bad, &result) == false);
On 2014/03/21 15:55:55, reed1 wrote:
> I think the right fix is
> 
> FindColor(...) == NULL

Done.

[reed1, 2014-03-24 13:26:35]

lgtm

[Krzysztof Olczyk, 2014-03-24 15:33:08]

The CQ bit was unchecked by kolczyk@opera.com

[Krzysztof Olczyk, 2014-03-24 15:33:09]

The CQ bit was checked by kolczyk@opera.com

[cmp, 2014-03-25 23:26:10]

On 2014/03/24 15:33:09, Krzysztof Olczyk wrote:
> The CQ bit was checked by mailto:kolczyk@opera.com

This CL has a bad base URL and it won't be picked up by the Skia CQ.  You should
get a fresh copy of the Skia source repo from skia.googlesource.com and post
your CL again from there.  (Or convert your Git repo to use the
skia.googlesource.com remote.)

[cmp, 2014-03-25 23:26:13]

The CQ bit was unchecked by cmp@chromium.org

[Sergey Berezin, 2014-03-25 23:34:44]

On 2014/03/24 15:33:09, Krzysztof Olczyk wrote:
> The CQ bit was checked by mailto:kolczyk@opera.com

The base URL is not recognized by CQ. You may have to commit manually, or fix
the base URL and re-upload as another CL.

[hcm, 2014-03-26 15:04:12]

On 2014/03/25 23:34:44, Sergey Berezin wrote:
> On 2014/03/24 15:33:09, Krzysztof Olczyk wrote:
> > The CQ bit was checked by mailto:kolczyk@opera.com
> 
> The base URL is not recognized by CQ. You may have to commit manually, or fix
> the base URL and re-upload as another CL.

We also still need Opera added to the Skia AUTHORS file

[Krzysztof Olczyk, 2014-04-04 08:09:52]

On 2014/03/25 23:34:44, Sergey Berezin wrote:
> On 2014/03/24 15:33:09, Krzysztof Olczyk wrote:
> > The CQ bit was checked by mailto:kolczyk@opera.com
> 
> The base URL is not recognized by CQ. You may have to commit manually, or fix
> the base URL and re-upload as another CL.

That's probably I submitted it from inside Chromium sources.
Re-uploaded from skia checkout.

[Krzysztof Olczyk, 2014-04-04 08:10:14]

The CQ bit was checked by kolczyk@opera.com

[commit-bot: I haz the power, 2014-04-04 08:15:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-04 08:15:06]

Commit queue rejected this change because it did not recognize the base URL.
Please commit your change manually.

[Krzysztof Olczyk, 2014-04-04 08:16:57]

On 2014/04/04 08:15:06, I haz the power (commit-bot) wrote:
> Commit queue rejected this change because it did not recognize the base URL.
> Please commit your change manually.

Now, I've followed the instructions from
https://sites.google.com/site/skiadocs/developer-documentation/contributing-c...
Does anybody have any idea why it has failed anyway?

[Sergey Berezin, 2014-04-04 21:02:30]

On 2014/04/04 08:16:57, Krzysztof Olczyk wrote:
> On 2014/04/04 08:15:06, I haz the power (commit-bot) wrote:
> > Commit queue rejected this change because it did not recognize the base URL.
> > Please commit your change manually.
> 
> Now, I've followed the instructions from
>
https://sites.google.com/site/skiadocs/developer-documentation/contributing-c...
> Does anybody have any idea why it has failed anyway?

You may want to re-upload your CL from scratch. I don't think there is an easy
way to update the base URL in Rietveld on the existing CL.

[Krzysztof Olczyk, 2014-04-07 09:51:34]

On 2014/04/04 21:02:30, Sergey Berezin wrote:
> On 2014/04/04 08:16:57, Krzysztof Olczyk wrote:
> > On 2014/04/04 08:15:06, I haz the power (commit-bot) wrote:
> > > Commit queue rejected this change because it did not recognize the base
URL.
> > > Please commit your change manually.
> > 
> > Now, I've followed the instructions from
> >
>
https://sites.google.com/site/skiadocs/developer-documentation/contributing-c...
> > Does anybody have any idea why it has failed anyway?
> 
> You may want to re-upload your CL from scratch. I don't think there is an easy
> way to update the base URL in Rietveld on the existing CL.

Done: https://codereview.chromium.org/227043006/