Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 2270363003: [TurboFan] Avoid Gcc compilation fail by Initializing rest_index variable. (Closed)

Created:
4 years, 4 months ago by zhengxing.li
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[TurboFan] Avoid Gcc compilation fail by Initializing rest_index variable. The CL #38858 (https://codereview.chromium.org/2269293004) removed the parameter assignment code in rest_parameter(int* index) function in Class DeclarationScope. This caused the Gcc compilation fail at the following code in src/compiler/ast-graph-builder.cc, line 576. int rest_index; Variable* rest_parameter = scope->rest_parameter(&rest_index); BuildRestArgumentsArray(rest_parameter, rest_index); The error message was: ../src/compiler/ast-graph-builder.cc: In member function ‘void v8::internal::compiler::AstGraphBuilder::CreateGraphBody(bool)’: ../src/compiler/ast-graph-builder.cc:578:54: error: ‘rest_index’ may be used uninitialized in this function [-Werror=maybe-uninitialized] BuildRestArgumentsArray(rest_parameter, rest_index); ^ This CL fixed this issue by intializing rest_index to 0. BUG= Committed: https://crrev.com/ce1386697f20e49daa424594dc905f2a4f1ddc0d Cr-Commit-Position: refs/heads/master@{#38863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 4 months ago (2016-08-24 10:41:22 UTC) #2
titzer
lgtm
4 years, 4 months ago (2016-08-24 10:42:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270363003/1
4 years, 4 months ago (2016-08-24 10:43:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 11:06:23 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 11:06:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ce1386697f20e49daa424594dc905f2a4f1ddc0d
Cr-Commit-Position: refs/heads/master@{#38863}

Powered by Google App Engine
This is Rietveld 408576698