Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2269293004: Replace rest_index_ with has_rest_ (Closed)

Created:
4 years, 4 months ago by Toon Verwaest
Modified:
4 years, 4 months ago
Reviewers:
neis
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Replace rest_index_ with has_rest_ rest_index_ is implicitly params_.length() - 1, since it can only be the last. Add dchecks that no parameters are added after the rest parameter. BUG=v8:5209 Committed: https://crrev.com/6e4d678db9aa9fe355cb6948a1f0d51451e3acc6 Cr-Commit-Position: refs/heads/master@{#38858}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -13 lines) Patch
M src/ast/scopes.h View 3 chunks +10 lines, -5 lines 0 comments Download
M src/ast/scopes.cc View 5 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
Toon Verwaest
ptal, the change you suggested.
4 years, 4 months ago (2016-08-24 05:10:56 UTC) #2
neis
On 2016/08/24 05:10:56, Toon Verwaest wrote: > ptal, the change you suggested. Thanks! Can you ...
4 years, 4 months ago (2016-08-24 08:28:03 UTC) #3
Toon Verwaest
Let's do it in a follow-up?
4 years, 4 months ago (2016-08-24 08:39:43 UTC) #4
neis
On 2016/08/24 08:39:43, Toon Verwaest wrote: > Let's do it in a follow-up? ok
4 years, 4 months ago (2016-08-24 08:41:16 UTC) #5
neis
lgtm
4 years, 4 months ago (2016-08-24 08:41:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2269293004/1
4 years, 4 months ago (2016-08-24 08:45:08 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 09:15:10 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 09:15:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e4d678db9aa9fe355cb6948a1f0d51451e3acc6
Cr-Commit-Position: refs/heads/master@{#38858}

Powered by Google App Engine
This is Rietveld 408576698