Issue 2270353002: openjpeg: Prevent an integer overflow in opj_pi_create_decode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2270353002: openjpeg: Prevent an integer overflow in opj_pi_create_decode. (Closed)

Created:
4 years, 4 months ago by Ke Liu

Modified:
4 years, 3 months ago

Reviewers:
Tom Sepez, dsinclair, Oliver Chang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Project:
pdfium

Visibility:
Public.

More Reviews

Description

openjpeg: Prevent an integer overflow in opj_pi_create_decode. The patch 0002-packet-iterator.patch for openjpeg is insufficient. This CL makes it more secure to call opj_calloc. BUG=chromium:639836 R=dsinclair@chromium.org

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	third_party/libopenjpeg20/pi.c	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ke Liu

Since another patch for openjpeg is under reviewing. Currently I'll not upload the patch file ...

4 years, 4 months ago (2016-08-24 03:39:27 UTC) #1

Tom Sepez

4 years, 3 months ago (2016-08-29 16:32:24 UTC) #4

On 2016/08/24 14:10:16, dsinclair wrote:

Closing without landing based upon wontfix of underlying bug.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages