third_party/libopenjpeg20/pi.c - Issue 2270353002: openjpeg: Prevent an integer overflow in opj_pi_create_decode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/libopenjpeg20/pi.c

Issue 2270353002: openjpeg: Prevent an integer overflow in opj_pi_create_decode. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/libopenjpeg20/pi.c

diff --git a/third_party/libopenjpeg20/pi.c b/third_party/libopenjpeg20/pi.c

index 9097e31a0ee8808cec207292a176e08ce445509e..0b62a3f7b6e6d2062aa2505053a94887d0b724f3 100644

--- a/third_party/libopenjpeg20/pi.c

+++ b/third_party/libopenjpeg20/pi.c

@@ -1248,7 +1248,7 @@ opj_pi_iterator_t *opj_pi_create_decode(opj_image_t *p_image,

/* memory allocation for include */

l_current_pi->include = 00;

- (l_step_l && l_tcp->numlayers < UINT_MAX / l_step_l - 1)

+ (l_step_l && l_tcp->numlayers < UINT_MAX / sizeof(OPJ_INT16) / l_step_l - 1)

{

l_current_pi->include = (OPJ_INT16*)opj_calloc((l_tcp->numlayers + 1) * l_step_l, sizeof(OPJ_INT16));

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »