Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4045)

Unified Diff: blimp/client/core/contents/android/blimp_view.h

Issue 2270323004: Add BlimpView to a Chrome tab when Blimp is enabled. (Closed)
Patch Set: Magic now happens Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/contents/android/blimp_view.h
diff --git a/blimp/client/core/contents/android/blimp_view.h b/blimp/client/core/contents/android/blimp_view.h
new file mode 100644
index 0000000000000000000000000000000000000000..e090b43c09c433ee488518156f68d7890faac80e
--- /dev/null
+++ b/blimp/client/core/contents/android/blimp_view.h
@@ -0,0 +1,37 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BLIMP_CLIENT_CORE_CONTENTS_ANDROID_BLIMP_VIEW_H_
+#define BLIMP_CLIENT_CORE_CONTENTS_ANDROID_BLIMP_VIEW_H_
+
+#include <jni.h>
+
+#include "base/android/jni_android.h"
+#include "base/android/scoped_java_ref.h"
+#include "ui/android/window_android.h"
+
+namespace blimp {
+namespace client {
+
+// The JNI bridge for the Java BlimpView that will visually represent the Blimp
David Trainor- moved to gerrit 2016/08/29 05:29:33 Can you explain that native creates the java side
nyquist 2016/08/29 19:09:19 Done.
+// rendered content.
+class BlimpView {
+ public:
+ BlimpView(JNIEnv* env,
David Trainor- moved to gerrit 2016/08/29 05:29:33 Should we just pull env internally?
nyquist 2016/08/29 19:09:19 Done.
+ ui::WindowAndroid* window,
+ jobject jblimp_contents_impl);
David Trainor- moved to gerrit 2016/08/29 05:29:33 Can we just store this natively and have Java just
nyquist 2016/08/29 19:09:19 Wow, that had a lot of nice consequences!
+ ~BlimpView();
+
+ base::android::ScopedJavaLocalRef<jobject> GetJavaObject();
+
+ private:
+ base::android::ScopedJavaGlobalRef<jobject> java_obj_;
+
+ DISALLOW_COPY_AND_ASSIGN(BlimpView);
+};
+
+} // namespace client
+} // namespace blimp
+
+#endif // BLIMP_CLIENT_CORE_CONTENTS_ANDROID_BLIMP_VIEW_H_

Powered by Google App Engine
This is Rietveld 408576698