Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 2270303002: Make WebAPK intent filter only match URLs within full scope (Closed)

Created:
4 years, 4 months ago by pkotwicz
Modified:
4 years, 4 months ago
Reviewers:
Xi Han, hartmanng
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make WebAPK intent filter only match URLs within full scope Previously the WebAPK intent filter matched all URLs within the scope origin. The CL makes the WebAPK intent filter only match URLs within the full WebAPK scope. BUG=640436 TEST=None Committed: https://crrev.com/cf3cdf887187f3ffb436618c871414db0e7f437e Cr-Commit-Position: refs/heads/master@{#414088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/android/webapk/shell_apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/webapk/shell_apk/BUILD.gn View 3 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
pkotwicz
Glenn and Xi can you please take a look?
4 years, 4 months ago (2016-08-24 00:53:48 UTC) #2
Xi Han
lgtm
4 years, 4 months ago (2016-08-24 13:51:19 UTC) #3
hartmanng
lgtm
4 years, 4 months ago (2016-08-24 14:01:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270303002/1
4 years, 4 months ago (2016-08-24 14:07:00 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-24 16:13:26 UTC) #7
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 16:15:25 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cf3cdf887187f3ffb436618c871414db0e7f437e
Cr-Commit-Position: refs/heads/master@{#414088}

Powered by Google App Engine
This is Rietveld 408576698