Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3543)

Unified Diff: chrome/android/webapk/shell_apk/BUILD.gn

Issue 2270303002: Make WebAPK intent filter only match URLs within full scope (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/webapk/shell_apk/AndroidManifest.xml ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/webapk/shell_apk/BUILD.gn
diff --git a/chrome/android/webapk/shell_apk/BUILD.gn b/chrome/android/webapk/shell_apk/BUILD.gn
index 26a02edf7e1287a4d4a10aeeb94ab30bc6489b24..fe65f3498a06375f17b491f364e279b6c7e5ca90 100644
--- a/chrome/android/webapk/shell_apk/BUILD.gn
+++ b/chrome/android/webapk/shell_apk/BUILD.gn
@@ -19,7 +19,7 @@ declare_args() {
webapk_start_url = "https://www.template.com/home_page"
webapk_name = "Longer Sample WebAPK Name"
webapk_short_name = "Sample WebAPK"
- webapk_scope_url = "https://www.template.com"
+ webapk_scope_url = "https://www.template.com/"
webapk_display_mode = "standalone"
webapk_orientation = "portrait"
webapk_theme_color = "2147483648L" # HostBrowserLauncher#MANIFEST_COLOR_INVALID_OR_MISSING
@@ -36,6 +36,9 @@ declare_args() {
# Host part of |webapk_scope_url|.
webapk_scope_url_host = "www.template.com"
+ # Path part of |webapk_scope_url|.
+ webapk_scope_url_path = "/"
+
# Android version code for the WebAPK.
webapk_version_code = "1"
@@ -66,6 +69,7 @@ jinja_template("shell_apk_manifest") {
"icon_url=$webapk_icon_url",
"icon_murmur2_hash=$webapk_icon_murmur2_hash",
"scope_url_host=$webapk_scope_url_host",
+ "scope_url_path=$webapk_scope_url_path",
"web_manifest_url=$webapk_web_manifest_url",
"version_code=$webapk_version_code",
"version_name=$webapk_version_name",
« no previous file with comments | « chrome/android/webapk/shell_apk/AndroidManifest.xml ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698