[Android] Implement empty view for download manager ui

[Android] Implement empty view for download manager ui

When there is no download item available, there should be a View telling
the user that the list is empty. Currently the download manger ui only
shows a blank screen if there are no items. This CL fixes this.

BUG=616324
Committed: https://crrev.com/e9ab1c0b3689d97cc12fa019c2b222737fe5896d
Cr-Commit-Position: refs/heads/master@{#414321}

[Ian Wen, 2016-08-24 00:43:18]

ianwen@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[Ian Wen, 2016-08-24 00:43:19]

PTAL

[gone, 2016-08-24 18:07:57]

lgtm

https://codereview.chromium.org/2270233003/diff/20001/chrome/android/java/res...
File chrome/android/java/res/layout/download_content.xml (right):

https://codereview.chromium.org/2270233003/diff/20001/chrome/android/java/res...
chrome/android/java/res/layout/download_content.xml:40:
android:layout_centerInParent="true"
This centers it relative to the RelativeLayout, doesn't it?  It should be
centered in the area below the toolbar.  Is this more of a stopgap?

[Ian Wen, 2016-08-24 18:32:30]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2016-08-24 18:32:42]

https://codereview.chromium.org/2270233003/diff/20001/chrome/android/java/res...
File chrome/android/java/res/layout/download_content.xml (right):

https://codereview.chromium.org/2270233003/diff/20001/chrome/android/java/res...
chrome/android/java/res/layout/download_content.xml:40:
android:layout_centerInParent="true"
On 2016/08/24 18:07:57, dfalcantara wrote:
> This centers it relative to the RelativeLayout, doesn't it?  It should be
> centered in the area below the toolbar.  Is this more of a stopgap?

Let's postpone it till the UX complains? :P

[commit-bot: I haz the power, 2016-08-24 18:33:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-24 23:04:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-24 23:04:04]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Ian Wen, 2016-08-25 03:52:51]

The CQ bit was checked by ianwen@chromium.org

[Ian Wen, 2016-08-25 03:52:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2270233003/#ps60001
(title: "don't use compound drawable")

[commit-bot: I haz the power, 2016-08-25 03:53:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-25 05:33:20]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-25 05:35:10]

Description was changed from

==========
[Android] Implement empty view for download manager ui

When there is no download item available, there should be a View telling
the user that the list is empty. Currently the download manger ui only
shows a blank screen if there are no items. This CL fixes this.

BUG=616324
==========

to

==========
[Android] Implement empty view for download manager ui

When there is no download item available, there should be a View telling
the user that the list is empty. Currently the download manger ui only
shows a blank screen if there are no items. This CL fixes this.

BUG=616324

Committed: https://crrev.com/e9ab1c0b3689d97cc12fa019c2b222737fe5896d
Cr-Commit-Position: refs/heads/master@{#414321}
==========

[commit-bot: I haz the power, 2016-08-25 05:35:11]

Patchset 4 (id:??) landed as
https://crrev.com/e9ab1c0b3689d97cc12fa019c2b222737fe5896d
Cr-Commit-Position: refs/heads/master@{#414321}