chrome/android/java/res/layout/download_content.xml - Issue 2270233003: [Android] Implement empty view for download manager ui

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/android/java/res/layout/download_content.xml

Issue 2270233003: [Android] Implement empty view for download manager ui (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add copyright to the xml drawable Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <?xml version="1.0" encoding="utf-8"?>

	2 <!-- Copyright 2016 The Chromium Authors. All rights reserved.

	3 Use of this source code is governed by a BSD-style license that can be

	4 found in the LICENSE file. -->

	5

	6 <RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"

	7 android:layout_width="match_parent"

	8 android:layout_height="match_parent"

	9 android:background="#ffffff"

	10 android:orientation="vertical" >

	11

	12 <org.chromium.chrome.browser.download.ui.DownloadManagerToolbar

	13 android:id="@+id/action_bar"

	14 android:layout_width="match_parent"

	15 android:layout_height="?attr/actionBarSize"

	16 android:background="@color/appbar_background"

	17 android:layout_alignParentTop="true" >

	18

	19 <include layout="@layout/number_roll_view" />

	20

	21 </org.chromium.chrome.browser.download.ui.DownloadManagerToolbar>

	22

	23 <android.support.v7.widget.RecyclerView

	24 android:id="@+id/recycler_view"

	25 android:layout_width="match_parent"

	26 android:layout_height="match_parent"

	27 android:layout_alignParentBottom="true"

	28 android:layout_below="@id/action_bar" />

	29

	30 <org.chromium.chrome.browser.widget.FadingShadowView

	31 android:id="@+id/shadow"

	32 android:layout_width="match_parent"

	33 android:layout_height="10dp"

	34 android:layout_below="@id/action_bar" />

	35

	36 <TextView

	37 android:id="@+id/empty_view"

	38 android:layout_width="wrap_content"

	39 android:layout_height="wrap_content"

	40 android:layout_centerInParent="true"
	gone 2016/08/24 18:07:57 This centers it relative to the RelativeLayout, do This centers it relative to the RelativeLayout, doesn't it? It should be centered in the area below the toolbar. Is this more of a stopgap? Ian Wen 2016/08/24 18:32:42 Let's postpone it till the UX complains? :P Show quoted text On 2016/08/24 18:07:57, dfalcantara wrote: > This centers it relative to the RelativeLayout, doesn't it? It should be > centered in the area below the toolbar. Is this more of a stopgap? Let's postpone it till the UX complains? :P
	41 android:gravity="center"

	42 android:padding="16dp"

	43 android:drawablePadding="3dp"

	44 android:text="@string/download_manager_ui_empty"

	45 android:textColor="#5B5B5B"

	46 android:textSize="16sp"

	47 android:visibility="gone" />

	48 </RelativeLayout>

OLD	NEW

« no previous file with comments | « chrome/android/java/res/layout-sw720dp/download_main.xml ('k') | chrome/android/java/res/layout/download_main.xml » ('j') | no next file with comments »