Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2270203002: Add Tex{Sub}Image function overloads with sub source. (Closed)

Created:
4 years, 4 months ago by Zhenyao Mo
Modified:
4 years, 4 months ago
CC:
chromium-reviews, blink-reviews, haraken, Kai Ninomiya
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Tex{Sub}Image function overloads with sub source. This is first part, where function implementation is to be added later. BUG=639145 TEST=gpu bots R=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/33f717b1e3bf71f5001e08040a17024a9c6fa1b0 Cr-Commit-Position: refs/heads/master@{#414090}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment typo #

Patch Set 3 : fix ArrayBufferView==nullptr #

Patch Set 4 : change the fix after spec fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -43 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h View 1 2 3 1 chunk +41 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 1 2 3 5 chunks +157 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl View 1 2 3 1 chunk +33 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 27 (15 generated)
Zhenyao Mo
kbr: PTAL
4 years, 4 months ago (2016-08-23 21:43:50 UTC) #3
Ken Russell (switch to Gerrit)
LGTM https://codereview.chromium.org/2270203002/diff/1/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h (right): https://codereview.chromium.org/2270203002/diff/1/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h#newcode105 third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h:105: // TODO(zmo): Obsoltete, remove after WebGL2 conformance tests ...
4 years, 4 months ago (2016-08-23 22:03:20 UTC) #5
Zhenyao Mo
https://codereview.chromium.org/2270203002/diff/1/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h (right): https://codereview.chromium.org/2270203002/diff/1/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h#newcode105 third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h:105: // TODO(zmo): Obsoltete, remove after WebGL2 conformance tests are ...
4 years, 4 months ago (2016-08-23 22:13:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270203002/20001
4 years, 4 months ago (2016-08-23 22:14:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270203002/40001
4 years, 4 months ago (2016-08-23 23:21:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270203002/60001
4 years, 4 months ago (2016-08-24 00:54:07 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/279579)
4 years, 4 months ago (2016-08-24 02:35:37 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270203002/60001
4 years, 4 months ago (2016-08-24 03:06:40 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/279669)
4 years, 4 months ago (2016-08-24 06:15:44 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2270203002/60001
4 years, 4 months ago (2016-08-24 15:25:14 UTC) #24
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-24 16:46:06 UTC) #25
commit-bot: I haz the power
4 years, 4 months ago (2016-08-24 16:47:59 UTC) #27
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/33f717b1e3bf71f5001e08040a17024a9c6fa1b0
Cr-Commit-Position: refs/heads/master@{#414090}

Powered by Google App Engine
This is Rietveld 408576698