Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2270193005: Update the generated public suffix file (Closed)

Created:
4 years, 3 months ago by Ryan Sleevi
Modified:
4 years, 3 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Update the generated public suffix file Commit 702d65e434b5a41965f5b9fbe644e9e4300157b6 updated the underlying data file, but the generated .gperf file was not re-generated because I forgot to run net/tools/tld_cleanup on it. TBR'ing because it's a file derived from the already reviewed CL. TBR=pkasting@chromium.org BUG=626532, 639677 Review-Url: https://codereview.chromium.org/2263923002 Cr-Commit-Position: refs/heads/master@{#413380} (cherry picked from commit a16e791c295658f7253f30ab7680ce74b7e0b93b) Committed: https://chromium.googlesource.com/chromium/src/+/9ec0afd588845ef505a04d3d4123949220fb18b8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -12 lines) Patch
M net/base/registry_controlled_domains/effective_tld_names.gperf View 39 chunks +32 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Ryan Sleevi
Committed patchset #1 (id:1) manually as 9ec0afd588845ef505a04d3d4123949220fb18b8.
4 years, 3 months ago (2016-08-25 18:06:09 UTC) #2
Peter Kasting
4 years, 3 months ago (2016-08-25 19:11:13 UTC) #3
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698