Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2263923002: Update the generated public suffix file (Closed)

Created:
4 years, 4 months ago by Ryan Sleevi
Modified:
4 years, 4 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the generated public suffix file Commit 702d65e434b5a41965f5b9fbe644e9e4300157b6 updated the underlying data file, but the generated .gperf file was not re-generated because I forgot to run net/tools/tld_cleanup on it. TBR'ing because it's a file derived from the already reviewed CL. TBR=pkasting@chromium.org BUG=626532, 639677 Committed: https://crrev.com/a16e791c295658f7253f30ab7680ce74b7e0b93b Cr-Commit-Position: refs/heads/master@{#413380}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -12 lines) Patch
M net/base/registry_controlled_domains/effective_tld_names.gperf View 39 chunks +32 lines, -12 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ryan Sleevi
TBR because I'm an idiot, and filed a follow-up bug to prevent such mistakes in ...
4 years, 4 months ago (2016-08-21 19:22:49 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2263923002/1
4 years, 4 months ago (2016-08-21 19:23:16 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-21 21:43:49 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a16e791c295658f7253f30ab7680ce74b7e0b93b Cr-Commit-Position: refs/heads/master@{#413380}
4 years, 4 months ago (2016-08-21 21:45:41 UTC) #6
Peter Kasting
4 years, 4 months ago (2016-08-22 00:56:09 UTC) #7
Message was sent while issue was closed.
Doh, I feel dumb for not noticing this.

LGTM

Powered by Google App Engine
This is Rietveld 408576698