Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Side by Side Diff: chrome/browser/usb/usb_chooser_controller_unittest.cc

Issue 2269993004: Add unit test for UsbChooserController (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@modify_UsbDeviceFilter_MatchesAny
Patch Set: address more comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include <memory>
6
7 #include "base/macros.h"
8 #include "base/memory/ref_counted.h"
9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/usb/usb_chooser_controller.h"
11 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
12 #include "content/public/test/web_contents_tester.h"
13 #include "device/core/mock_device_client.h"
14 #include "device/usb/mock_usb_device.h"
15 #include "device/usb/mock_usb_service.h"
16 #include "device/usb/public/interfaces/device_manager.mojom.h"
17 #include "mojo/public/cpp/bindings/array.h"
18 #include "testing/gtest/include/gtest/gtest.h"
19 #include "url/gurl.h"
20
21 namespace {
22
23 const char kDefaultTestUrl[] = "https://www.google.com/";
24
25 } // namespace
26
27 class UsbChooserControllerTest : public ChromeRenderViewHostTestHarness {
28 public:
29 UsbChooserControllerTest() {}
30 ~UsbChooserControllerTest() override = default;
31
32 void SetUp() override {
33 ChromeRenderViewHostTestHarness::SetUp();
34
35 mojo::Array<device::usb::DeviceFilterPtr> device_filters;
36 device::usb::ChooserService::GetPermissionCallback callback;
37 content::WebContentsTester* web_contents_tester =
38 content::WebContentsTester::For(web_contents());
39 web_contents_tester->NavigateAndCommit(GURL(kDefaultTestUrl));
40 usb_chooser_controller_.reset(new UsbChooserController(
41 main_rfh(), std::move(device_filters), main_rfh(), callback));
42 }
43
44 protected:
45 scoped_refptr<device::MockUsbDevice> CreateMockUsbDevice(
46 const std::string& product_string,
47 const std::string& serial_number) {
48 scoped_refptr<device::MockUsbDevice> device(new device::MockUsbDevice(
49 0, 1, "Google", product_string, serial_number));
50 std::unique_ptr<device::WebUsbAllowedOrigins> webusb_allowed_origins(
51 new device::WebUsbAllowedOrigins());
52 webusb_allowed_origins->origins.push_back(GURL(kDefaultTestUrl));
53 device->set_webusb_allowed_origins(std::move(webusb_allowed_origins));
54 return device;
55 }
56
57 device::MockDeviceClient device_client_;
58 std::unique_ptr<UsbChooserController> usb_chooser_controller_;
59
60 private:
61 DISALLOW_COPY_AND_ASSIGN(UsbChooserControllerTest);
62 };
63
64 TEST_F(UsbChooserControllerTest, AddDevice) {
65 scoped_refptr<device::MockUsbDevice> device_a =
66 CreateMockUsbDevice("a", "001");
67 device_client_.usb_service()->AddDevice(device_a);
68 EXPECT_EQ(1u, usb_chooser_controller_->NumOptions());
69 EXPECT_EQ(base::ASCIIToUTF16("a"), usb_chooser_controller_->GetOption(0));
70
71 scoped_refptr<device::MockUsbDevice> device_b =
72 CreateMockUsbDevice("b", "002");
73 device_client_.usb_service()->AddDevice(device_b);
74 EXPECT_EQ(2u, usb_chooser_controller_->NumOptions());
75 EXPECT_EQ(base::ASCIIToUTF16("b"), usb_chooser_controller_->GetOption(1));
76
77 scoped_refptr<device::MockUsbDevice> device_c =
78 CreateMockUsbDevice("c", "003");
79 device_client_.usb_service()->AddDevice(device_c);
80 EXPECT_EQ(3u, usb_chooser_controller_->NumOptions());
81 EXPECT_EQ(base::ASCIIToUTF16("c"), usb_chooser_controller_->GetOption(2));
82 }
83
84 TEST_F(UsbChooserControllerTest, RemoveDevice) {
85 scoped_refptr<device::MockUsbDevice> device_a =
86 CreateMockUsbDevice("a", "001");
87 device_client_.usb_service()->AddDevice(device_a);
88 scoped_refptr<device::MockUsbDevice> device_b =
89 CreateMockUsbDevice("b", "002");
90 device_client_.usb_service()->AddDevice(device_b);
91 scoped_refptr<device::MockUsbDevice> device_c =
92 CreateMockUsbDevice("c", "003");
93 device_client_.usb_service()->AddDevice(device_c);
94
95 device_client_.usb_service()->RemoveDevice(device_b);
96 EXPECT_EQ(2u, usb_chooser_controller_->NumOptions());
97 EXPECT_EQ(base::ASCIIToUTF16("a"), usb_chooser_controller_->GetOption(0));
98 EXPECT_EQ(base::ASCIIToUTF16("c"), usb_chooser_controller_->GetOption(1));
99
100 // Remove a non-existent device, the number of devices should not change.
101 scoped_refptr<device::MockUsbDevice> device_non_existent =
102 CreateMockUsbDevice("d", "001");
103 device_client_.usb_service()->RemoveDevice(device_non_existent);
104 EXPECT_EQ(2u, usb_chooser_controller_->NumOptions());
105 EXPECT_EQ(base::ASCIIToUTF16("a"), usb_chooser_controller_->GetOption(0));
106 EXPECT_EQ(base::ASCIIToUTF16("c"), usb_chooser_controller_->GetOption(1));
107
108 device_client_.usb_service()->RemoveDevice(device_a);
109 EXPECT_EQ(1u, usb_chooser_controller_->NumOptions());
110 EXPECT_EQ(base::ASCIIToUTF16("c"), usb_chooser_controller_->GetOption(0));
111
112 device_client_.usb_service()->RemoveDevice(device_c);
113 EXPECT_EQ(0u, usb_chooser_controller_->NumOptions());
114 }
115
116 TEST_F(UsbChooserControllerTest, AddAndRemoveDeviceWithSameName) {
117 scoped_refptr<device::MockUsbDevice> device_a_1 =
118 CreateMockUsbDevice("a", "001");
119 device_client_.usb_service()->AddDevice(device_a_1);
120 EXPECT_EQ(base::ASCIIToUTF16("a"), usb_chooser_controller_->GetOption(0));
121 scoped_refptr<device::MockUsbDevice> device_b =
122 CreateMockUsbDevice("b", "002");
123 device_client_.usb_service()->AddDevice(device_b);
124 scoped_refptr<device::MockUsbDevice> device_a_2 =
125 CreateMockUsbDevice("a", "002");
126 device_client_.usb_service()->AddDevice(device_a_2);
127 EXPECT_EQ(base::ASCIIToUTF16("a (001)"),
128 usb_chooser_controller_->GetOption(0));
129 EXPECT_EQ(base::ASCIIToUTF16("b"), usb_chooser_controller_->GetOption(1));
130 EXPECT_EQ(base::ASCIIToUTF16("a (002)"),
131 usb_chooser_controller_->GetOption(2));
132
133 device_client_.usb_service()->RemoveDevice(device_a_1);
134 EXPECT_EQ(base::ASCIIToUTF16("b"), usb_chooser_controller_->GetOption(0));
135 EXPECT_EQ(base::ASCIIToUTF16("a"), usb_chooser_controller_->GetOption(1));
136 }
OLDNEW
« no previous file with comments | « no previous file | chrome/chrome_tests_unit.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698