Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Unified Diff: chrome/common/search/search_types.h

Issue 2269933002: Instant cleanup: remove MODE_SEARCH_RESULTS and ORIGIN_SEARCH (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_url_replacement
Patch Set: review Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/search/search_model_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/search/search_types.h
diff --git a/chrome/common/search/search_types.h b/chrome/common/search/search_types.h
index 4da3ad99276e538ea86fda6128812d13c3021081..9523bcb190de3027ee4f437573bb4593cdb2a486 100644
--- a/chrome/common/search/search_types.h
+++ b/chrome/common/search/search_types.h
@@ -18,10 +18,6 @@ struct SearchMode {
// The Omnibox is modified in some way, either on the NTP or not.
MODE_SEARCH_SUGGESTIONS,
-
- // On a search results page.
- // TODO(treib): Remove this; it's not used anymore. crbug.com/627747
- MODE_SEARCH_RESULTS,
};
// The kind of page from which the user initiated the current search.
@@ -31,10 +27,6 @@ struct SearchMode {
// The user is searching from the NTP.
ORIGIN_NTP,
-
- // The user is searching from a search results page.
- // TODO(treib): Remove this; it's not used anymore. crbug.com/627747
- ORIGIN_SEARCH,
};
SearchMode() : mode(MODE_DEFAULT), origin(ORIGIN_DEFAULT) {
@@ -61,14 +53,6 @@ struct SearchMode {
return mode == MODE_NTP;
}
- bool is_search() const {
- return mode == MODE_SEARCH_SUGGESTIONS || mode == MODE_SEARCH_RESULTS;
- }
-
- bool is_search_results() const {
- return mode == MODE_SEARCH_RESULTS;
- }
-
bool is_search_suggestions() const {
return mode == MODE_SEARCH_SUGGESTIONS;
}
@@ -77,10 +61,6 @@ struct SearchMode {
return origin == ORIGIN_DEFAULT;
}
- bool is_origin_search() const {
- return origin == ORIGIN_SEARCH;
- }
-
bool is_origin_ntp() const {
return origin == ORIGIN_NTP;
}
« no previous file with comments | « chrome/browser/ui/search/search_model_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698